You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Miklos Gergely (JIRA)" <ji...@apache.org> on 2018/11/01 07:16:00 UTC
[jira] [Updated] (HIVE-20807) Refactor LlapStatusServiceDriver
[ https://issues.apache.org/jira/browse/HIVE-20807?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Miklos Gergely updated HIVE-20807:
----------------------------------
Status: Patch Available (was: Open)
> Refactor LlapStatusServiceDriver
> --------------------------------
>
> Key: HIVE-20807
> URL: https://issues.apache.org/jira/browse/HIVE-20807
> Project: Hive
> Issue Type: Improvement
> Components: Hive
> Affects Versions: 4.0.0
> Reporter: Miklos Gergely
> Assignee: Miklos Gergely
> Priority: Major
> Fix For: 4.0.0
>
> Attachments: HIVE-20807.01.patch, HIVE-20807.02.patch, HIVE-20807.03.patch, HIVE-20807.04.patch
>
>
> LlapStatusServiceDriver is the class used to determine if LLAP has started. The following problems should be solved by refactoring:
> 1. The main class is more than 800 lines long,should be cut into multiple smaller classes.
> 2. The current design makes it extremely hard to write unit tests.
> 3. There are some overcomplicated, over-engineered parts of the code.
> 4. Most of the code is under org.apache.hadoop.hive.llap.cli, but some parts are under org.apache.hadoop.hive.llap.cli.status. The whole program could be moved to the latter.
> 5. LlapStatusHelpers serves as a class for holding classes, which doesn't make much sense.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)