You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexei Zakharov (JIRA)" <ji...@apache.org> on 2006/09/20 15:51:22 UTC
[jira] Created: (HARMONY-1506) [classlib][beans] new fixes for
DefaultPersistenceDelegateTest failures
[classlib][beans] new fixes for DefaultPersistenceDelegateTest failures
-----------------------------------------------------------------------
Key: HARMONY-1506
URL: http://issues.apache.org/jira/browse/HARMONY-1506
Project: Harmony
Issue Type: Improvement
Components: Classlib
Environment: winXP
Reporter: Alexei Zakharov
Attachments: DefaultPDTest-1506.patch
The following tests from the org.apache.harmony.beans.tests.java.beans. DefaultPersistenceDelegateTest are affected (enabled) by the attached patch.
testInstantiate_NotRegularGetter
Failed because the test was optimized for buggy RI behavior, see HARMONY-1503. The test was corrected.
testMutatesTo_NormalNoProperty
testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
I have corrected the assertion about comparing two strings "test1" and "test2" because
1) DefaultPersisteceDelegate will never be called for comparing Strings in normal conditions. It is the job of StringPersistenceDelegate.
2) I definitely cannot imagine the circumstances in which one String object "test1" can "mutate" to another String object "test2". Strings are immutable. So IMHO there is completely no sense in returning true from mutatesTo("test1", "test2").
testMutatesTo_NormalWithPropertyNoEqualMethod
testMutatesTo_NormalWithNullPropertyPublicEqualMethod
testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
testMutatesTo_NormalWithPropertyPublicEqualMethod
testMutatesTo_NormalWithPropertyProtectedEqualMethod
I have corrected the style a little bit. In fact I don't see much sense in testing of various types of visibility of the equals() method. But since somebody has written this already I just keep it untouched.
testMutatesTo_Null
Fails on RI also. The test was corrected. Now it passes on Harmony as well as on RI.
Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1506) [classlib][beans] new fixes for
DefaultPersistenceDelegateTest failures
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1506?page=comments#action_12441288 ]
Tim Ellison commented on HARMONY-1506:
--------------------------------------
Alexei, this patch is quite out of date (sorry about that). Please can you provide an updated patch?
Thanks
Tim
> [classlib][beans] new fixes for DefaultPersistenceDelegateTest failures
> -----------------------------------------------------------------------
>
> Key: HARMONY-1506
> URL: http://issues.apache.org/jira/browse/HARMONY-1506
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Attachments: DefaultPDTest-1506.patch
>
>
> The following tests from the org.apache.harmony.beans.tests.java.beans. DefaultPersistenceDelegateTest are affected (enabled) by the attached patch.
> testInstantiate_NotRegularGetter
> Failed because the test was optimized for buggy RI behavior, see HARMONY-1503. The test was corrected.
> testMutatesTo_NormalNoProperty
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> I have corrected the assertion about comparing two strings "test1" and "test2" because
> 1) DefaultPersisteceDelegate will never be called for comparing Strings in normal conditions. It is the job of StringPersistenceDelegate.
> 2) I definitely cannot imagine the circumstances in which one String object "test1" can "mutate" to another String object "test2". Strings are immutable. So IMHO there is completely no sense in returning true from mutatesTo("test1", "test2").
> testMutatesTo_NormalWithPropertyNoEqualMethod
> testMutatesTo_NormalWithNullPropertyPublicEqualMethod
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyProtectedEqualMethod
> I have corrected the style a little bit. In fact I don't see much sense in testing of various types of visibility of the equals() method. But since somebody has written this already I just keep it untouched.
> testMutatesTo_Null
> Fails on RI also. The test was corrected. Now it passes on Harmony as well as on RI.
> Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1506) [classlib][beans] new fixes for
DefaultPersistenceDelegateTest failures
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1506?page=comments#action_12442643 ]
Alexei Zakharov commented on HARMONY-1506:
------------------------------------------
Yes, all tests pass. Thanks Tim.
> [classlib][beans] new fixes for DefaultPersistenceDelegateTest failures
> -----------------------------------------------------------------------
>
> Key: HARMONY-1506
> URL: http://issues.apache.org/jira/browse/HARMONY-1506
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Tim Ellison
> Attachments: DefaultPDTest-1506.patch, DefaultPDTest-1506_updated.patch
>
>
> The following tests from the org.apache.harmony.beans.tests.java.beans. DefaultPersistenceDelegateTest are affected (enabled) by the attached patch.
> testInstantiate_NotRegularGetter
> Failed because the test was optimized for buggy RI behavior, see HARMONY-1503. The test was corrected.
> testMutatesTo_NormalNoProperty
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> I have corrected the assertion about comparing two strings "test1" and "test2" because
> 1) DefaultPersisteceDelegate will never be called for comparing Strings in normal conditions. It is the job of StringPersistenceDelegate.
> 2) I definitely cannot imagine the circumstances in which one String object "test1" can "mutate" to another String object "test2". Strings are immutable. So IMHO there is completely no sense in returning true from mutatesTo("test1", "test2").
> testMutatesTo_NormalWithPropertyNoEqualMethod
> testMutatesTo_NormalWithNullPropertyPublicEqualMethod
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyProtectedEqualMethod
> I have corrected the style a little bit. In fact I don't see much sense in testing of various types of visibility of the equals() method. But since somebody has written this already I just keep it untouched.
> testMutatesTo_Null
> Fails on RI also. The test was corrected. Now it passes on Harmony as well as on RI.
> Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1506) [classlib][beans] new fixes for
DefaultPersistenceDelegateTest failures
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1506?page=all ]
Tim Ellison resolved HARMONY-1506.
----------------------------------
Resolution: Fixed
Thanks Alexei,
Patch applied to BEANS module at repo revision r464477.
Please check that the patch was applied as you expected.
> [classlib][beans] new fixes for DefaultPersistenceDelegateTest failures
> -----------------------------------------------------------------------
>
> Key: HARMONY-1506
> URL: http://issues.apache.org/jira/browse/HARMONY-1506
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Tim Ellison
> Attachments: DefaultPDTest-1506.patch, DefaultPDTest-1506_updated.patch
>
>
> The following tests from the org.apache.harmony.beans.tests.java.beans. DefaultPersistenceDelegateTest are affected (enabled) by the attached patch.
> testInstantiate_NotRegularGetter
> Failed because the test was optimized for buggy RI behavior, see HARMONY-1503. The test was corrected.
> testMutatesTo_NormalNoProperty
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> I have corrected the assertion about comparing two strings "test1" and "test2" because
> 1) DefaultPersisteceDelegate will never be called for comparing Strings in normal conditions. It is the job of StringPersistenceDelegate.
> 2) I definitely cannot imagine the circumstances in which one String object "test1" can "mutate" to another String object "test2". Strings are immutable. So IMHO there is completely no sense in returning true from mutatesTo("test1", "test2").
> testMutatesTo_NormalWithPropertyNoEqualMethod
> testMutatesTo_NormalWithNullPropertyPublicEqualMethod
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyProtectedEqualMethod
> I have corrected the style a little bit. In fact I don't see much sense in testing of various types of visibility of the equals() method. But since somebody has written this already I just keep it untouched.
> testMutatesTo_Null
> Fails on RI also. The test was corrected. Now it passes on Harmony as well as on RI.
> Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1506) [classlib][beans] new fixes for
DefaultPersistenceDelegateTest failures
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1506?page=all ]
Alexei Zakharov updated HARMONY-1506:
-------------------------------------
Attachment: DefaultPDTest-1506.patch
patch for test
> [classlib][beans] new fixes for DefaultPersistenceDelegateTest failures
> -----------------------------------------------------------------------
>
> Key: HARMONY-1506
> URL: http://issues.apache.org/jira/browse/HARMONY-1506
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Attachments: DefaultPDTest-1506.patch
>
>
> The following tests from the org.apache.harmony.beans.tests.java.beans. DefaultPersistenceDelegateTest are affected (enabled) by the attached patch.
> testInstantiate_NotRegularGetter
> Failed because the test was optimized for buggy RI behavior, see HARMONY-1503. The test was corrected.
> testMutatesTo_NormalNoProperty
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> I have corrected the assertion about comparing two strings "test1" and "test2" because
> 1) DefaultPersisteceDelegate will never be called for comparing Strings in normal conditions. It is the job of StringPersistenceDelegate.
> 2) I definitely cannot imagine the circumstances in which one String object "test1" can "mutate" to another String object "test2". Strings are immutable. So IMHO there is completely no sense in returning true from mutatesTo("test1", "test2").
> testMutatesTo_NormalWithPropertyNoEqualMethod
> testMutatesTo_NormalWithNullPropertyPublicEqualMethod
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyProtectedEqualMethod
> I have corrected the style a little bit. In fact I don't see much sense in testing of various types of visibility of the equals() method. But since somebody has written this already I just keep it untouched.
> testMutatesTo_Null
> Fails on RI also. The test was corrected. Now it passes on Harmony as well as on RI.
> Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1506) [classlib][beans] new fixes for
DefaultPersistenceDelegateTest failures
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1506?page=all ]
Tim Ellison closed HARMONY-1506.
--------------------------------
Verified by Alexei.
> [classlib][beans] new fixes for DefaultPersistenceDelegateTest failures
> -----------------------------------------------------------------------
>
> Key: HARMONY-1506
> URL: http://issues.apache.org/jira/browse/HARMONY-1506
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Tim Ellison
> Attachments: DefaultPDTest-1506.patch, DefaultPDTest-1506_updated.patch
>
>
> The following tests from the org.apache.harmony.beans.tests.java.beans. DefaultPersistenceDelegateTest are affected (enabled) by the attached patch.
> testInstantiate_NotRegularGetter
> Failed because the test was optimized for buggy RI behavior, see HARMONY-1503. The test was corrected.
> testMutatesTo_NormalNoProperty
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> I have corrected the assertion about comparing two strings "test1" and "test2" because
> 1) DefaultPersisteceDelegate will never be called for comparing Strings in normal conditions. It is the job of StringPersistenceDelegate.
> 2) I definitely cannot imagine the circumstances in which one String object "test1" can "mutate" to another String object "test2". Strings are immutable. So IMHO there is completely no sense in returning true from mutatesTo("test1", "test2").
> testMutatesTo_NormalWithPropertyNoEqualMethod
> testMutatesTo_NormalWithNullPropertyPublicEqualMethod
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyProtectedEqualMethod
> I have corrected the style a little bit. In fact I don't see much sense in testing of various types of visibility of the equals() method. But since somebody has written this already I just keep it untouched.
> testMutatesTo_Null
> Fails on RI also. The test was corrected. Now it passes on Harmony as well as on RI.
> Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1506) [classlib][beans] new fixes for
DefaultPersistenceDelegateTest failures
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1506?page=all ]
Tim Ellison reassigned HARMONY-1506:
------------------------------------
Assignee: Tim Ellison
> [classlib][beans] new fixes for DefaultPersistenceDelegateTest failures
> -----------------------------------------------------------------------
>
> Key: HARMONY-1506
> URL: http://issues.apache.org/jira/browse/HARMONY-1506
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Assigned To: Tim Ellison
> Attachments: DefaultPDTest-1506.patch, DefaultPDTest-1506_updated.patch
>
>
> The following tests from the org.apache.harmony.beans.tests.java.beans. DefaultPersistenceDelegateTest are affected (enabled) by the attached patch.
> testInstantiate_NotRegularGetter
> Failed because the test was optimized for buggy RI behavior, see HARMONY-1503. The test was corrected.
> testMutatesTo_NormalNoProperty
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> I have corrected the assertion about comparing two strings "test1" and "test2" because
> 1) DefaultPersisteceDelegate will never be called for comparing Strings in normal conditions. It is the job of StringPersistenceDelegate.
> 2) I definitely cannot imagine the circumstances in which one String object "test1" can "mutate" to another String object "test2". Strings are immutable. So IMHO there is completely no sense in returning true from mutatesTo("test1", "test2").
> testMutatesTo_NormalWithPropertyNoEqualMethod
> testMutatesTo_NormalWithNullPropertyPublicEqualMethod
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyProtectedEqualMethod
> I have corrected the style a little bit. In fact I don't see much sense in testing of various types of visibility of the equals() method. But since somebody has written this already I just keep it untouched.
> testMutatesTo_Null
> Fails on RI also. The test was corrected. Now it passes on Harmony as well as on RI.
> Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1506) [classlib][beans] new fixes for
DefaultPersistenceDelegateTest failures
Posted by "Alexei Zakharov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1506?page=all ]
Alexei Zakharov updated HARMONY-1506:
-------------------------------------
Attachment: DefaultPDTest-1506_updated.patch
Sure Tim. Please see the updated patch.
> [classlib][beans] new fixes for DefaultPersistenceDelegateTest failures
> -----------------------------------------------------------------------
>
> Key: HARMONY-1506
> URL: http://issues.apache.org/jira/browse/HARMONY-1506
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Environment: winXP
> Reporter: Alexei Zakharov
> Attachments: DefaultPDTest-1506.patch, DefaultPDTest-1506_updated.patch
>
>
> The following tests from the org.apache.harmony.beans.tests.java.beans. DefaultPersistenceDelegateTest are affected (enabled) by the attached patch.
> testInstantiate_NotRegularGetter
> Failed because the test was optimized for buggy RI behavior, see HARMONY-1503. The test was corrected.
> testMutatesTo_NormalNoProperty
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> I have corrected the assertion about comparing two strings "test1" and "test2" because
> 1) DefaultPersisteceDelegate will never be called for comparing Strings in normal conditions. It is the job of StringPersistenceDelegate.
> 2) I definitely cannot imagine the circumstances in which one String object "test1" can "mutate" to another String object "test2". Strings are immutable. So IMHO there is completely no sense in returning true from mutatesTo("test1", "test2").
> testMutatesTo_NormalWithPropertyNoEqualMethod
> testMutatesTo_NormalWithNullPropertyPublicEqualMethod
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyProtectedEqualMethod
> I have corrected the style a little bit. In fact I don't see much sense in testing of various types of visibility of the equals() method. But since somebody has written this already I just keep it untouched.
> testMutatesTo_Null
> Fails on RI also. The test was corrected. Now it passes on Harmony as well as on RI.
> Thanks.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira