You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/06/08 20:14:58 UTC

Re: [PR] GH-41475: [Python] Build with py313 [arrow]

kou commented on code in PR #42034:
URL: https://github.com/apache/arrow/pull/42034#discussion_r1632102656


##########
python/pyarrow/src/arrow/python/udf.cc:
##########
@@ -28,6 +28,11 @@
 #include "arrow/util/checked_cast.h"
 #include "arrow/util/logging.h"
 
+#if PY_VERSION_HEX >= 0x030D00A4
+#define __Py_IsFinalizing Py_IsFinalizing
+#else
+#define __Py_IsFinalizing _Py_IsFinalizing
+#endif

Review Comment:
   How about always using `Py_IsFinalizing` (new API)?
   
   ```suggestion
   #if PY_VERSION_HEX < 0x030D00A4
   #define Py_IsFinalizing() _Py_IsFinalizing()
   #endif
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org