You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/09/22 10:02:44 UTC
[GitHub] [arrow-datafusion] tustvold opened a new pull request, #3584: Make ObjectStoreProvider fallible
tustvold opened a new pull request, #3584:
URL: https://github.com/apache/arrow-datafusion/pull/3584
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
https://github.com/apache/arrow-datafusion/pull/3540#issuecomment-1254598498
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Makes `ObjectStoreProvider::get_by_url` fallible and clarifies some docs
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3584: Make ObjectStoreProvider fallible (return `Result` rather than `Option`)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3584:
URL: https://github.com/apache/arrow-datafusion/pull/3584#issuecomment-1254885912
Benchmark runs are scheduled for baseline = a080c03060eae5d19432f0e83b125a61c2625a41 and contender = be6ad1ce93a69a33f0e51e7aeab41c466b466a06. be6ad1ce93a69a33f0e51e7aeab41c466b466a06 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/8d0514f8a22a482aaa8d833cec6d4f03...ae7f435a63284233a40025951ca73017/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/b2b7b897215441b8bdcf951350b5dc77...87b8d7d79940450db268019714e51d4a/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/096929cfad7a49f88ba39d243ef31858...353d90ad6357404593aa7d15803f697e/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5157c1e7d7b444c59aadb9ca17047152...f1974068ccd446cab193bb68592a1ade/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3584: Make ObjectStoreProvider fallible (return `Result` rather than `Option`)
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3584:
URL: https://github.com/apache/arrow-datafusion/pull/3584#issuecomment-1256148491
Follow on PR and discussion for `Result<Option>` is https://github.com/apache/arrow-datafusion/pull/3595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yahoNanJing commented on a diff in pull request #3584: Make ObjectStoreProvider fallible (return `Result` rather than `Option`)
Posted by GitBox <gi...@apache.org>.
yahoNanJing commented on code in PR #3584:
URL: https://github.com/apache/arrow-datafusion/pull/3584#discussion_r978203623
##########
datafusion/core/src/datasource/object_store.rs:
##########
@@ -83,9 +83,8 @@ impl std::fmt::Display for ObjectStoreUrl {
/// Object store provider can detector an object store based on the url
pub trait ObjectStoreProvider: Send + Sync + 'static {
- /// Detector a suitable object store based on its url if possible
- /// Return the key and object store
- fn get_by_url(&self, url: &Url) -> Option<Arc<dyn ObjectStore>>;
+ /// Return an ObjectStore for the provided url based on its scheme and authority
+ fn get_by_url(&self, url: &Url) -> Result<Arc<dyn ObjectStore>>;
Review Comment:
Better to change it to be
```
Result<Option<Arc<dyn ObjectStore>>>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3584: Make ObjectStoreProvider fallible (return `Result` rather than `Option`)
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3584:
URL: https://github.com/apache/arrow-datafusion/pull/3584#issuecomment-1254859013
Thanks @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #3584: Make ObjectStoreProvider fallible (return `Result` rather than `Option`)
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3584:
URL: https://github.com/apache/arrow-datafusion/pull/3584#issuecomment-1254864864
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/3584?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3584](https://codecov.io/gh/apache/arrow-datafusion/pull/3584?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (067a25c) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/b54a56f35dcdc518887aff12806b9080ae0cf1da?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b54a56f) will **decrease** coverage by `0.00%`.
> The diff coverage is `20.00%`.
```diff
@@ Coverage Diff @@
## master #3584 +/- ##
==========================================
- Coverage 86.03% 86.02% -0.01%
==========================================
Files 300 300
Lines 56253 56250 -3
==========================================
- Hits 48395 48390 -5
- Misses 7858 7860 +2
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/3584?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [datafusion/core/src/datasource/object\_store.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9kYXRhc291cmNlL29iamVjdF9zdG9yZS5ycw==) | `85.05% <20.00%> (+0.61%)` | :arrow_up: |
| [datafusion/expr/src/logical\_plan/plan.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9leHByL3NyYy9sb2dpY2FsX3BsYW4vcGxhbi5ycw==) | `77.10% <0.00%> (-0.33%)` | :arrow_down: |
| [datafusion/common/src/scalar.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/3584/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL3NjYWxhci5ycw==) | `85.18% <0.00%> (-0.07%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yahoNanJing commented on a diff in pull request #3584: Make ObjectStoreProvider fallible (return `Result` rather than `Option`)
Posted by GitBox <gi...@apache.org>.
yahoNanJing commented on code in PR #3584:
URL: https://github.com/apache/arrow-datafusion/pull/3584#discussion_r978203623
##########
datafusion/core/src/datasource/object_store.rs:
##########
@@ -83,9 +83,8 @@ impl std::fmt::Display for ObjectStoreUrl {
/// Object store provider can detector an object store based on the url
pub trait ObjectStoreProvider: Send + Sync + 'static {
- /// Detector a suitable object store based on its url if possible
- /// Return the key and object store
- fn get_by_url(&self, url: &Url) -> Option<Arc<dyn ObjectStore>>;
+ /// Return an ObjectStore for the provided url based on its scheme and authority
+ fn get_by_url(&self, url: &Url) -> Result<Arc<dyn ObjectStore>>;
Review Comment:
Better to change it to be Result<Option<Arc<dyn ObjectStore>>>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] yahoNanJing commented on pull request #3584: Make ObjectStoreProvider fallible (return `Result` rather than `Option`)
Posted by GitBox <gi...@apache.org>.
yahoNanJing commented on PR #3584:
URL: https://github.com/apache/arrow-datafusion/pull/3584#issuecomment-1255719823
Thanks @alamb for this info. I think better to change the return type to be
```
Result<Option<Arc<dyn ObjectStore>>>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] tustvold merged pull request #3584: Make ObjectStoreProvider fallible (return `Result` rather than `Option`)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3584:
URL: https://github.com/apache/arrow-datafusion/pull/3584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org