[GitHub] [activemq-nms-amqp] michaelpearce-gain commented on a change in pull request #4: AMQNET-589: Failover implementation

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #4: AMQNET-589: Failover implementation
URL: https://github.com/apache/activemq-nms-amqp/pull/4#discussion_r302893170
 
 

 ##########
 File path: src/NMS.AMQP/SessionDispatcher.cs
 ##########
 @@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+using System.Threading;
+using System.Threading.Tasks;
+using System.Threading.Tasks.Dataflow;
+
+namespace Apache.NMS.AMQP
+{
+    internal class SessionDispatcher
+    {
+        private readonly ActionBlock<NmsMessageConsumer.MessageDeliveryTask> actionBlock;
+        private int dispatchThreadId;
+        private readonly CancellationTokenSource cts;
+
+        public SessionDispatcher()
+        {
+            cts = new CancellationTokenSource();
+            actionBlock = new ActionBlock<NmsMessageConsumer.MessageDeliveryTask>(HandleTask, new ExecutionDataflowBlockOptions
+            {
+                EnsureOrdered = true,
+                MaxDegreeOfParallelism = 1,
+                CancellationToken = cts.Token
+            });
+        }
+
+        public void Post(NmsMessageConsumer.MessageDeliveryTask task) => actionBlock.Post(task);
+
+        public bool IsOnDeliveryThread() => dispatchThreadId == Thread.CurrentThread.ManagedThreadId;
+
+        private void HandleTask(NmsMessageConsumer.MessageDeliveryTask messageDeliveryTask)
+        {
+            try
+            {
+                dispatchThreadId = Thread.CurrentThread.ManagedThreadId;
+                messageDeliveryTask.DeliverNextPending();
+            }
+            finally
+            {
+                dispatchThreadId = -1;
+            }
+        }
+
+        public void Stop()
+        {
+            actionBlock.Complete();
+            cts.Cancel();
 
 Review comment:
   Just to add here, i think as anyhow the intent of this library is to really be the NMS equiv of the QPID JMS lib for AMQP, taking design decisions from there, where it has been used in production environments will mean we will have hopefully less suprises, also end users will get same experience.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services