You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/13 22:28:52 UTC

[GitHub] [arrow] kou commented on a change in pull request #9096: ARROW-11212: [Packaging][Python] Use vcpkg as dependency source for manylinux and windows wheels

kou commented on a change in pull request #9096:
URL: https://github.com/apache/arrow/pull/9096#discussion_r556910519



##########
File path: dev/tasks/python-wheels/osx-build.sh
##########
@@ -91,6 +92,7 @@ function build_wheel {
           -DCMAKE_INSTALL_PREFIX=$ARROW_HOME \
           -DMAKE=make \
           -DProtobuf_SOURCE=SYSTEM \
+          -DgRPC_PROTOBUF_PACKAGE_TYPE=SYSTEM \

Review comment:
       I think that this is needless.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org