[GitHub] [iceberg] rymurr commented on pull request #1905: Remove sun's jersey

[GitBox <gi...@apache.org>]

rymurr commented on pull request #1905:
URL: https://github.com/apache/iceberg/pull/1905#issuecomment-743186804


   Hey @rdblue
   
   Sorry, more info:
   
   1. `com.sun.jersey` is only in test dependencies for the various spark/hive/flink/mr modules. Basically anywhere we user hadoop 2.7 libs. So this doesn't affect runtime.
   
   2. This occurs anywhere you try and use newer `javax.ws.rs` packages as Jersey1.9 sneakily has overlapping pacakges in `com.sun.jersey:jersey-client`. So i have seen this specifically when working w/ Nessie and Spark or Hive tests (in the iceberg repo or the Nessie repo). The Nessie client loads `javax` packages and hits a variation on `java.lang.AbstractMethodError: javax.ws.rs.core.UriBuilder.uri(Ljava/lang/String;)Ljavax/ws/rs/core/UriBuilder;`. This is a pre-cursor patch to some fixes to allow Nessie as a custom catalog in the hive reader.
   
   A quick check shows that Spark doesn't ship this old jersey (even though its a dep of hadoop 2.7) nor do some Hives. 
   
   From my understanding the only thing this change does is allow us to use modern REST clients from unit tests and it will have no effect on runtime. I could take a more subtle approach and add an exclude for each test dependency if you prefer.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org