You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/05 09:45:58 UTC
[GitHub] [fineract] vorburger opened a new pull request #821: add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)
vorburger opened a new pull request #821:
URL: https://github.com/apache/fineract/pull/821
This will catch problems such as the integration tests running "too early" (before Flyway has fully initialized the database), which I have a suspicion could be one of (many) causes of the unstable scheduler tests, notably because of the IllegalArgumentException at SchedulerJobsTest.java:90 in #817.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #821: add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #821:
URL: https://github.com/apache/fineract/pull/821#issuecomment-623973277
Failed due to `testInterestTransferForSavings()` and thus requires #815 ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #821: add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #821:
URL: https://github.com/apache/fineract/pull/821
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] xurror commented on pull request #821: add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)
Posted by GitBox <gi...@apache.org>.
xurror commented on pull request #821:
URL: https://github.com/apache/fineract/pull/821#issuecomment-629744149
Couldn't help but notice references to 2 different issues in your commits. Changes are very little though. I don't know if they are co-dependent but would have been much better to raise 2 different PRs for each of them. But as I said, very little changes so, I don't mind if you merge it like this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #821: add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #821:
URL: https://github.com/apache/fineract/pull/821#issuecomment-629724594
@awasum @ptuomola @xurror wanna review this one from 2 weeks ago - OK to merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ptuomola commented on pull request #821: add new testNumberOfJobs() to SchedulerJobsTest (re. FINERACT-922)
Posted by GitBox <gi...@apache.org>.
ptuomola commented on pull request #821:
URL: https://github.com/apache/fineract/pull/821#issuecomment-629741840
Looks good to me!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org