You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@knox.apache.org by GitBox <gi...@apache.org> on 2022/05/20 19:14:27 UTC

[GitHub] [knox] risdenk commented on a diff in pull request #579: KNOX-2726 - Impersonation Params should be configurable

risdenk commented on code in PR #579:
URL: https://github.com/apache/knox/pull/579#discussion_r878477770


##########
gateway-provider-identity-assertion-common/pom.xml:
##########
@@ -85,8 +85,23 @@
             <groupId>org.eclipse.jetty</groupId>
             <artifactId>jetty-util</artifactId>
         </dependency>
+        <dependency>
+            <groupId>org.jboss.shrinkwrap.descriptors</groupId>
+            <artifactId>shrinkwrap-descriptors-api-javaee</artifactId>
+            <scope>compile</scope>

Review Comment:
   Don't set scope to compile. Not needed by default. Thats why you don't see `<scope>compile</scope>` anywhere else.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org