You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Kikyou1997 (via GitHub)" <gi...@apache.org> on 2023/11/20 03:30:47 UTC
[PR] [minor](optimizer) add table to slot reference [doris]
Kikyou1997 opened a new pull request, #27261:
URL: https://github.com/apache/doris/pull/27261
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](optimizer) add table to slot reference [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27261:
URL: https://github.com/apache/doris/pull/27261#issuecomment-1818488109
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.28 seconds
stream load tsv: 569 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 33 seconds loaded 861443392 Bytes, about 24 MB/s
insert into select: 28.9 seconds inserted 10000000 Rows, about 346K ops/s
storage size: 17098766084 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](optimizer) add table to slot reference [doris]
Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on PR #27261:
URL: https://github.com/apache/doris/pull/27261#issuecomment-1818440399
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](optimizer) add table to slot reference [doris]
Posted by "englefly (via GitHub)" <gi...@apache.org>.
englefly commented on code in PR #27261:
URL: https://github.com/apache/doris/pull/27261#discussion_r1399010867
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/SlotReference.java:
##########
@@ -80,30 +85,32 @@ public SlotReference(ExprId exprId, String name, DataType dataType, boolean null
* @param internalName the internalName of this slot
*/
public SlotReference(ExprId exprId, String name, DataType dataType, boolean nullable,
- List<String> qualifier, @Nullable Column column, Optional<String> internalName) {
+ List<String> qualifier, @Nullable Column column, Optional<String> internalName,
+ TableIf table) {
this.exprId = exprId;
this.name = name;
this.dataType = dataType;
this.qualifier = ImmutableList.copyOf(Objects.requireNonNull(qualifier, "qualifier can not be null"));
this.nullable = nullable;
this.column = column;
this.internalName = internalName.isPresent() ? internalName : Optional.of(name);
+ this.table = table;
}
public static SlotReference of(String name, DataType type) {
return new SlotReference(name, type);
}
- public static SlotReference fromColumn(Column column, List<String> qualifier) {
+ public static SlotReference fromTableAndColumn(TableIf table, Column column, List<String> qualifier) {
Review Comment:
it is better to remove fromColumn() if it is not used any more
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](optimizer) add table to slot reference [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27261:
URL: https://github.com/apache/doris/pull/27261#issuecomment-1818258292
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.9 seconds
stream load tsv: 564 seconds loaded 74807831229 Bytes, about 126 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.4 seconds inserted 10000000 Rows, about 352K ops/s
storage size: 17099430760 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](optimizer) add table to slot reference [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #27261:
URL: https://github.com/apache/doris/pull/27261#issuecomment-1818472218
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 8f0bbab63ec59e534facbcacbcb7d1d21fa9a064, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4899 4636 4648 4636
q2 357 156 159 156
q3 2028 1925 1960 1925
q4 1393 1220 1250 1220
q5 4003 3976 4056 3976
q6 252 132 133 132
q7 1430 895 884 884
q8 2753 2801 2779 2779
q9 9681 9664 9674 9664
q10 3471 3576 3544 3544
q11 381 256 254 254
q12 439 289 294 289
q13 4596 3794 3807 3794
q14 313 289 289 289
q15 584 535 527 527
q16 668 588 585 585
q17 1139 990 944 944
q18 7885 7283 7366 7283
q19 1694 1695 1704 1695
q20 579 287 288 287
q21 4421 3978 3987 3978
q22 476 365 376 365
Total cold run time: 53442 ms
Total hot run time: 49206 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4611 4585 4591 4585
q2 337 237 241 237
q3 4001 4005 4004 4004
q4 2724 2708 2707 2707
q5 9727 9667 9603 9603
q6 245 122 125 122
q7 3054 2443 2420 2420
q8 4444 4473 4464 4464
q9 13225 13097 13168 13097
q10 4133 4240 4203 4203
q11 812 635 649 635
q12 974 806 840 806
q13 4306 3598 3583 3583
q14 383 370 361 361
q15 578 519 518 518
q16 739 672 669 669
q17 3897 3851 3941 3851
q18 9422 9143 9087 9087
q19 1820 1796 1788 1788
q20 2414 2087 2035 2035
q21 9000 8783 8737 8737
q22 912 825 804 804
Total cold run time: 81758 ms
Total hot run time: 78316 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](optimizer) add table to slot reference [doris]
Posted by "Kikyou1997 (via GitHub)" <gi...@apache.org>.
Kikyou1997 commented on PR #27261:
URL: https://github.com/apache/doris/pull/27261#issuecomment-1818172307
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [minor](optimizer) add table to slot reference [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow closed pull request #27261: [minor](optimizer) add table to slot reference
URL: https://github.com/apache/doris/pull/27261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org