[jira] [Commented] (SAMZA-1429) Add callback success/failure metrics to async tasks

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-1429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16184929#comment-16184929 ] 

ASF GitHub Bot commented on SAMZA-1429:
---------------------------------------

GitHub user dnishimura opened a pull request:

    https://github.com/apache/samza/pull/306

    SAMZA-1429: Add callback success/failure metrics to async tasks

    @jmakes & @nickpan47 please take a look when you get the chance.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dnishimura/samza samza-1429-async-metrics

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/306.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #306
    
----
commit e84685ab65548b120478d92e55167a562432bf14
Author: Daniel Nishimura <dn...@gmail.com>
Date:   2017-09-28T21:22:23Z

    Add completed and failure counters as metrics for AsyncTasks.

----


> Add callback success/failure metrics to async tasks
> ---------------------------------------------------
>
>                 Key: SAMZA-1429
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1429
>             Project: Samza
>          Issue Type: Improvement
>    Affects Versions: 0.14.0
>            Reporter: Daniel Nishimura
>            Assignee: Daniel Nishimura
>
> It would be useful to add callbacks success/failure counters as metrics s.t. we know how many callbacks succeeded vs failed vs number of process_calls.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)