You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/03/01 00:12:47 UTC

[kudu-CR] KUDU-1904 Don't seek on empty RLE blocks

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6184

to look at the new patch set (#5).

Change subject: KUDU-1904 Don't seek on empty RLE blocks
......................................................................

KUDU-1904 Don't seek on empty RLE blocks

Seeking in RLE blocks enforces that the seek position is less than
the number of elements in the block. If the number of elements is 0,
as it is when the entire set of cells is NULL, this check will always
result in a crash.

This patch enforces that the block only seeks if there are elements
in the block.

Test coverage will be added in an upcoming commit.

Change-Id: I6d6bd95099c9f30aa923a0da1e76f92ed90ebd99
---
M src/kudu/cfile/rle_block.h
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/6184/5
-- 
To view, visit http://gerrit.cloudera.org:8080/6184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6d6bd95099c9f30aa923a0da1e76f92ed90ebd99
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>