You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Roman Shtykh (JIRA)" <ji...@apache.org> on 2016/11/15 01:19:58 UTC

[jira] [Comment Edited] (IGNITE-4198) Ignite Kafka sink connector should have an option to transform Kafka values

    [ https://issues.apache.org/jira/browse/IGNITE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15665619#comment-15665619 ] 

Roman Shtykh edited comment on IGNITE-4198 at 11/15/16 1:19 AM:
----------------------------------------------------------------

Hi Vladimir,

Thank you for reviewing the issue!

1) I looked at other Kafka Connect Sink implementations. Normally people throw {{ConnectedException}}. I did the same way.
2) You are right. I renamed it.
Also probably we have to do something with the current extractors in ver. 2.0, as discussed in IGNITE-1370. I think having one interface with two methods is good. What do you think?


was (Author: roman_s):
Hi Vladimir,

Thank you for reviewing the issue!

1) I looked at other Kafka Connect Sink implementations. Normally people throw {{ConnectedException}}. I did the same way.
2) You are right. I renamed it. Also probably we have to do something with the current extractors in ver. 2.0, as discussed in IGNITE-1370.

> Ignite Kafka sink connector should have an option to transform Kafka values
> ---------------------------------------------------------------------------
>
>                 Key: IGNITE-4198
>                 URL: https://issues.apache.org/jira/browse/IGNITE-4198
>             Project: Ignite
>          Issue Type: Improvement
>          Components: streaming
>    Affects Versions: 1.7
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>              Labels: community, streaming
>             Fix For: 1.8
>
>
> Currently the connector takes a Kafka key and uses it as an Ignite key. However, Kafka keys can be null, and users may want to specify an Ignite key from the value object.
> Instead of creating a new transformer interface, I think we can use {{StreamMultipleTupleExtractor}} whenever its implementation is specified by the user in connector config file.
> http://apache-ignite-users.70518.x6.nabble.com/Kafka-Failed-to-stream-a-record-with-null-key-td8731.html



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)