You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2022/02/08 15:39:50 UTC

[GitHub] [cordova-docs] welrachid opened a new pull request #1230: removed link to not-working website (phising? or ads)

welrachid opened a new pull request #1230:
URL: https://github.com/apache/cordova-docs/pull/1230


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   None
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   sizeclasses.com is no longer providing any infomation. Looks like its been taken over by phising site/ads site. Therefore a link to that site might be a security risk for visitors. 
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Just removed a couple of lines
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   None
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   
   Only text edits.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] breautek merged pull request #1230: removed link to not-working website (phising? or ads)

Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1230:
URL: https://github.com/apache/cordova-docs/pull/1230


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] breautek edited a comment on pull request #1230: removed link to not-working website (phising? or ads)

Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #1230:
URL: https://github.com/apache/cordova-docs/pull/1230#issuecomment-1032752908


   ~Actually could you also add the change to the `dev/` version of the docs to avoid it being re-entered in the future?~
   
   Actually this actually fed from the plugin repos at https://github.com/apache/cordova-plugin-splashscreen/blob/master/README.md


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] breautek commented on pull request #1230: removed link to not-working website (phising? or ads)

Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1230:
URL: https://github.com/apache/cordova-docs/pull/1230#issuecomment-1032752908


   Actually could you also add the change to the `dev/` version of the docs to avoid it being re-entered in the future?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] breautek edited a comment on pull request #1230: removed link to not-working website (phising? or ads)

Posted by GitBox <gi...@apache.org>.
breautek edited a comment on pull request #1230:
URL: https://github.com/apache/cordova-docs/pull/1230#issuecomment-1032751592


   Thanks for the find & contribution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] breautek commented on pull request #1230: removed link to not-working website (phising? or ads)

Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1230:
URL: https://github.com/apache/cordova-docs/pull/1230#issuecomment-1032751592


   Thanks for the find & contribution, I'll try to get this snapshotted into the live site asap.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org