You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/18 05:02:17 UTC
[GitHub] [pulsar] merlimat opened a new pull request #14740: Fixed duplicated delayed messages when all consumers disconnect
merlimat opened a new pull request #14740:
URL: https://github.com/apache/pulsar/pull/14740
### Motivation
When all consumers are disconnected (eg: for a moment there's no consumer connected) and then reconnect, the delayed messages on that topic can be delivered twice.
The problem is that we're rewinding the subscription cursor but the delayed message tracker is not cleared, thus we're going to insert them messages back into the tracker which is not able to detect duplicates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14740: Fixed duplicated delayed messages when all consumers disconnect
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14740:
URL: https://github.com/apache/pulsar/pull/14740#issuecomment-1072033379
@merlimat:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on pull request #14740: [fix][broker]: fixed duplicated delayed messages when all consumers disconnect
Posted by GitBox <gi...@apache.org>.
Jason918 commented on pull request #14740:
URL: https://github.com/apache/pulsar/pull/14740#issuecomment-1072972481
It seems #14727 covers the case of this PR. And the solution is similar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #14740: Fixed duplicated delayed messages when all consumers disconnect
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #14740:
URL: https://github.com/apache/pulsar/pull/14740#issuecomment-1072086681
@merlimat is this a bug fix and we do not need to update docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #14740: Fixed duplicated delayed messages when all consumers disconnect
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #14740:
URL: https://github.com/apache/pulsar/pull/14740#issuecomment-1072086681
@merlimat is this a bug fix and we do not need to update docs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14740: Fixed duplicated delayed messages when all consumers disconnect
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14740:
URL: https://github.com/apache/pulsar/pull/14740#issuecomment-1072033379
@merlimat:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14740: [fix][broker]: fixed duplicated delayed messages when all consumers disconnect
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14740:
URL: https://github.com/apache/pulsar/pull/14740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org