[GitHub] [beam] clairemcginty commented on a diff in pull request #26557: Render inputDir in HadoopFormatIO.Read DisplayData

["clairemcginty (via GitHub)" <gi...@apache.org>]

clairemcginty commented on code in PR #26557:
URL: https://github.com/apache/beam/pull/26557#discussion_r1185325099


##########
sdks/java/io/hadoop-format/src/main/java/org/apache/beam/sdk/io/hadoop/format/HadoopFormatIO.java:
##########
@@ -702,6 +702,11 @@ public void populateDisplayData(DisplayData.Builder builder) {
                     "mapreduce.job.inputformat.class",
                     hadoopConfig.get("mapreduce.job.inputformat.class"))
                 .withLabel("InputFormat Class"));
+        builder.addIfNotNull(
+            DisplayData.item(
+                    "mapreduce.input.fileinputformat.inputdir",
+                    hadoopConfig.get("mapreduce.input.fileinputformat.inputdir"))

Review Comment:
   I'm a little unsure if we should add a safeguarding string-truncation here: technically Hadoop allows you to set a [list of comma-separated paths](https://github.com/apache/hadoop/blob/207c92753fc4782ebab3995eb8e4a2a62c744f27/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/lib/input/FileInputFormat.java#L524) as input, so this could potentially be very long. Maybe we can clip it at 250 chars? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org