You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/25 07:27:48 UTC

[GitHub] [flink] BiGsuw opened a new pull request, #19564: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

BiGsuw opened a new pull request, #19564:
URL: https://github.com/apache/flink/pull/19564

   What is the purpose of the change
   Update the flink-table/flink-table-common and flink-formats/flink-json module to AssertJ and JUnit 5 following the [JUnit 5 Migration Guide](https://docs.google.com/document/d/1514Wa_aNB9bJUen4xm5uiuXOooOJTtXqS_Jqk9KJitU/edit)
   
   Brief change log
   Use JUnit5 and AssertJ in tests instead of JUnit4 and Hamcrest
   Ignore deprecated class test case upgrades(JsonRowSerializationSchemaTest.class,JsonRowDeserializationSchemaTest.class)
   
   Verifying this change
   This change is a code cleanup without any test coverage.
   
   Does this pull request potentially affect one of the following parts:
   Dependencies (does it add or upgrade a dependency): ( no)
   The public API, i.e., is any changed class annotated with @Public(Evolving): ( no)
   The serializers: (no)
   The runtime per-record code paths (performance sensitive): (no)
   Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
   The S3 file system connector: ( no)
   Documentation
   Does this pull request introduce a new feature? ( no)
   If yes, how is the feature documented? (not applicable)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #19564: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #19564:
URL: https://github.com/apache/flink/pull/19564#issuecomment-1108183821

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a8b574f28db6ebead1c8a0516665d05e10be111a",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a8b574f28db6ebead1c8a0516665d05e10be111a",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a8b574f28db6ebead1c8a0516665d05e10be111a UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] BiGsuw closed pull request #19564: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

Posted by GitBox <gi...@apache.org>.
BiGsuw closed pull request #19564: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json
URL: https://github.com/apache/flink/pull/19564


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] BiGsuw commented on pull request #19564: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

Posted by GitBox <gi...@apache.org>.
BiGsuw commented on PR #19564:
URL: https://github.com/apache/flink/pull/19564#issuecomment-1110541540

   > ## CI report:
   > * [bd1c9f5](https://github.com/apache/flink/commit/bd1c9f50f4efa4fc07afc15be8391266cf87e70b) Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=35158)
   > 
   > Bot commands
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] BiGsuw commented on pull request #19564: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

Posted by GitBox <gi...@apache.org>.
BiGsuw commented on PR #19564:
URL: https://github.com/apache/flink/pull/19564#issuecomment-1113010229

   Could you help to check it ? Thanks. @zentol 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] BiGsuw commented on pull request #19564: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

Posted by GitBox <gi...@apache.org>.
BiGsuw commented on PR #19564:
URL: https://github.com/apache/flink/pull/19564#issuecomment-1110503797

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] BiGsuw commented on pull request #19564: [FLINK-27352][tests] [JUnit5 Migration] Module: flink-json

Posted by GitBox <gi...@apache.org>.
BiGsuw commented on PR #19564:
URL: https://github.com/apache/flink/pull/19564#issuecomment-1110541072

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org