You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/23 14:26:26 UTC
[GitHub] [spark] bjornjorgensen opened a new pull request, #38774: [SPARK-XXXX][CONNECT] Upgrade `Protobuf` to 3.19.5
bjornjorgensen opened a new pull request, #38774:
URL: https://github.com/apache/spark/pull/38774
### What changes were proposed in this pull request?
Upgrade Protobuf from 3.19.4 to 3.19.5
### Why are the changes needed?
[CVE-2022-1941](https://nvd.nist.gov/vuln/detail/CVE-2022-1941)
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38774: [SPARK-41240][CONNECT][BUILD][INFRA][DOCS] Upgrade `Protobuf` to 3.19.5
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38774:
URL: https://github.com/apache/spark/pull/38774#issuecomment-1327769622
Just found an effort to unify the protobuf version which impacted connect server: https://github.com/apache/spark/pull/38783
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38774: [SPARK-41240][CONNECT][BUILD][INFRA][DOCS] Upgrade `Protobuf` to 3.19.5
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38774:
URL: https://github.com/apache/spark/pull/38774#issuecomment-1327190992
merged into master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on pull request #38774: [SPARK-41240][CONNECT][BUILD][INFRA] Upgrade `Protobuf` to 3.19.5
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on PR #38774:
URL: https://github.com/apache/spark/pull/38774#issuecomment-1326180581
There is currently no updated version on the buf schema registry. Given that this runs remotely, I think we're good for now. Mayber we can leave a comment with a todo JIRA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38774: [SPARK-41240][CONNECT][BUILD][INFRA] Upgrade `Protobuf` to 3.19.5
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38774:
URL: https://github.com/apache/spark/pull/38774#issuecomment-1326069519
we may also need to change this place https://github.com/apache/spark/blob/master/connector/connect/src/main/buf.gen.yaml#L30
cc @grundprinzip
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38774: [SPARK-41240][CONNECT][BUILD][INFRA][DOCS] Upgrade `Protobuf` to 3.19.5
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38774:
URL: https://github.com/apache/spark/pull/38774#issuecomment-1327761392
Question:
Should we keep the protobuf version in sync between the server and client? The server side now is using:
`<protobuf.version>3.21.9</protobuf.version>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #38774: [SPARK-41240][CONNECT][BUILD][INFRA][DOCS] Upgrade `Protobuf` to 3.19.5
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #38774:
URL: https://github.com/apache/spark/pull/38774#issuecomment-1327384502
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on pull request #38774: [SPARK-41240][CONNECT][BUILD][INFRA] Upgrade `Protobuf` to 3.19.5
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on PR #38774:
URL: https://github.com/apache/spark/pull/38774#issuecomment-1326180884
https://buf.build/protocolbuffers/plugins/python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38774: [SPARK-41240][CONNECT][BUILD][INFRA][DOCS] Upgrade `Protobuf` to 3.19.5
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38774:
URL: https://github.com/apache/spark/pull/38774#issuecomment-1327189092
create https://issues.apache.org/jira/browse/SPARK-41265 to track buf.build/protocolbuffers/plugins/python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #38774: [SPARK-41240][CONNECT][BUILD][INFRA][DOCS] Upgrade `Protobuf` to 3.19.5
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #38774: [SPARK-41240][CONNECT][BUILD][INFRA][DOCS] Upgrade `Protobuf` to 3.19.5
URL: https://github.com/apache/spark/pull/38774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org