You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/17 13:46:05 UTC
[GitHub] [arrow] jorisvandenbossche opened a new pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
jorisvandenbossche opened a new pull request #10346:
URL: https://github.com/apache/arrow/pull/10346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10346:
URL: https://github.com/apache/arrow/pull/10346#issuecomment-842338279
https://issues.apache.org/jira/browse/ARROW-12806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #10346:
URL: https://github.com/apache/arrow/pull/10346#issuecomment-842339249
This begs the question if we should have a "minimal build" for python as well that turns the tests, otherwise we are to keep forget adding such markers (although in this case if that minimal build didn't include pandas, we still wouldn't have watched that error)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10346:
URL: https://github.com/apache/arrow/pull/10346#issuecomment-842377278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #10346:
URL: https://github.com/apache/arrow/pull/10346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #10346:
URL: https://github.com/apache/arrow/pull/10346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #10346:
URL: https://github.com/apache/arrow/pull/10346#issuecomment-842434925
> I think it'd make sense for a minimal build to still include Pandas, since it doesn't change anything about the build itself, and would enable more tests, right?
Yes, indeed, that doesn't impact the build. Having no pandas installed is also a case to test, but we actually do have a "no-pandas" build, so that is already covered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #10346:
URL: https://github.com/apache/arrow/pull/10346#issuecomment-842339249
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10346:
URL: https://github.com/apache/arrow/pull/10346#issuecomment-842392532
Should this also get cherry-picked into 4.0.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10346:
URL: https://github.com/apache/arrow/pull/10346#issuecomment-842364016
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #10346:
URL: https://github.com/apache/arrow/pull/10346#issuecomment-842364016
I think it'd make sense for a minimal build to still include Pandas, since it doesn't change anything about the build itself, and would enable more tests, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10346:
URL: https://github.com/apache/arrow/pull/10346#issuecomment-842338279
https://issues.apache.org/jira/browse/ARROW-12806
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10346:
URL: https://github.com/apache/arrow/pull/10346#issuecomment-842377278
Sounds like a good idea to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #10346: ARROW-12806: [Python] test_write_to_dataset_filesystem missing a dataset mark
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #10346:
URL: https://github.com/apache/arrow/pull/10346#issuecomment-842420035
While it's not essential, it shouldn't cause any trouble. Added to 4.0.1 jira version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org