You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/04/07 17:19:01 UTC
[GitHub] [incubator-superset] MarcusSorealheis opened a new pull request
#9485: Adding Nigeria to countries controls list.
MarcusSorealheis opened a new pull request #9485: Adding Nigeria to countries controls list.
URL: https://github.com/apache/incubator-superset/pull/9485
### CATEGORY
simple UI update.
- [ ] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
Quickly added his country (Nigeria) to the controls list per request by a guy in Slack.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
None at this time.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
This PR may not be the solution to his problem. Only trying to help. I thought I opened this PR already but I guess I didn't.
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
### REVIEWERS
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on issue #9485: Adding
Nigeria to countries controls list.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #9485: Adding Nigeria to countries controls list.
URL: https://github.com/apache/incubator-superset/pull/9485#issuecomment-610578151
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9485?src=pr&el=h1) Report
> Merging [#9485](https://codecov.io/gh/apache/incubator-superset/pull/9485?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/25e38f6ca7a34784e72284811309a99cec564e83&el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9485?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9485 +/- ##
==========================================
- Coverage 59.01% 58.76% -0.25%
==========================================
Files 383 385 +2
Lines 12191 12237 +46
Branches 3014 3020 +6
==========================================
- Hits 7194 7191 -3
- Misses 4813 4862 +49
Partials 184 184
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9485?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9485/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `42.85% <ø> (-0.12%)` | :arrow_down: |
| [...et-frontend/src/explore/controlPanels/DeckMulti.js](https://codecov.io/gh/apache/incubator-superset/pull/9485/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrTXVsdGkuanM=) | `0.00% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/DeckGeojson.js](https://codecov.io/gh/apache/incubator-superset/pull/9485/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrR2VvanNvbi5qcw==) | `0.00% <0.00%> (ø)` | |
| [...-frontend/src/explore/controlPanels/DeckScatter.js](https://codecov.io/gh/apache/incubator-superset/pull/9485/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrU2NhdHRlci5qcw==) | `0.00% <0.00%> (ø)` | |
| [...rset-frontend/src/explore/controlPanels/DeckArc.js](https://codecov.io/gh/apache/incubator-superset/pull/9485/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9EZWNrQXJjLmpz) | `0.00% <0.00%> (ø)` | |
| [...ontend/src/explore/controlPanels/Shared\_DeckGL.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9485/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFBhbmVscy9TaGFyZWRfRGVja0dMLmpzeA==) | `0.00% <0.00%> (ø)` | |
| [...rontend/src/explore/components/PropertiesModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9485/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Qcm9wZXJ0aWVzTW9kYWwudHN4) | `13.23% <0.00%> (+0.53%)` | :arrow_up: |
| [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9485/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | `48.00% <0.00%> (+2.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9485?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9485?src=pr&el=footer). Last update [25e38f6...7405558](https://codecov.io/gh/apache/incubator-superset/pull/9485?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] MarcusSorealheis commented on issue #9485:
Adding Nigeria to countries controls list.
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis commented on issue #9485: Adding Nigeria to countries controls list.
URL: https://github.com/apache/incubator-superset/pull/9485#issuecomment-610793588
I'm closing this issue because I asked him to simply type it in and that should work well enough. My apologies for not thinking about this before when he firs asked me. :face_palm::skin-tone-5:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] MarcusSorealheis edited a comment on issue
#9485: Adding Nigeria to countries controls list.
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis edited a comment on issue #9485: Adding Nigeria to countries controls list.
URL: https://github.com/apache/incubator-superset/pull/9485#issuecomment-610793588
I'm closing this issue because I asked him to simply type it in and that should work well enough. My apologies for not thinking about this before when he first asked me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] MarcusSorealheis closed pull request #9485:
Adding Nigeria to countries controls list.
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis closed pull request #9485: Adding Nigeria to countries controls list.
URL: https://github.com/apache/incubator-superset/pull/9485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] MarcusSorealheis edited a comment on issue
#9485: Adding Nigeria to countries controls list.
Posted by GitBox <gi...@apache.org>.
MarcusSorealheis edited a comment on issue #9485: Adding Nigeria to countries controls list.
URL: https://github.com/apache/incubator-superset/pull/9485#issuecomment-610793588
I'm closing this PR because I asked him to simply type it in and that should work well enough. My apologies for not thinking about this before when he first asked me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org