[jira] [Commented] (HTRACE-67) The go build should put downloaded files into a separate directory

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272826#comment-14272826 ] 

Colin Patrick McCabe commented on HTRACE-67:
--------------------------------------------

So the big picture for this patch is that I eliminated the generation of version.go, and put downloaded source files into a new {{build/}} subdirectory.  It fixes "mvn clean" to work even when there is no .git file in the root of the repo (i.e. it is not a git repository), which will be helpful for releases.

The one remaining source of generated files that get splatted into {{src/}} is the bundler, which I did not alter in this patch.  I think maybe we'll get rid of the bundler eventually, so I didn't want to mess with it here.

Details:
* cleans up the .gitignore.  With separate source and build directories, not many entries are needed.  However, previously catalog.go was gitignored, and it should not have been, so fix that.
* {{mvn clean}} should simply call {{gobuild.sh clean}}.  And that command should simply remove the {{build}} and {{pkg}} directories.  (There is still a little hack remaining in gobuild.sh clean to remove the files the bundler generates.)
* Remove {{generate_version.sh}}, since it is no longer needed.  Instead, we pass the git hash and the release version to the go compiler, so that it can place them into variables read by htraced and the htrace tool.
* The default action in gobuild.sh is now install rather than build, since build does not result in binaries getting installed into GOBIN (oops)
* simplify {{gobuild.sh}} by using a case statement on the action type

> The go build should put downloaded files into a separate directory
> ------------------------------------------------------------------
>
>                 Key: HTRACE-67
>                 URL: https://issues.apache.org/jira/browse/HTRACE-67
>             Project: HTrace
>          Issue Type: Improvement
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>             Fix For: 3.1.0
>
>         Attachments: HTRACE-67.001.patch
>
>
> The go build should put downloaded files into a separate directory.  This will make it easier to produce a reasonable "mvn clean" implementation that doesn't depend on git for its functioning.  It will make the .gitignore file simpler and less in need of updates.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)