You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Andy Grundman (JIRA)" <ji...@apache.org> on 2011/05/16 19:37:47 UTC

[jira] [Created] (THRIFT-1171) Perl write/readDouble assumes little-endian platform

Perl write/readDouble assumes little-endian platform
----------------------------------------------------

                 Key: THRIFT-1171
                 URL: https://issues.apache.org/jira/browse/THRIFT-1171
             Project: Thrift
          Issue Type: Bug
          Components: Perl - Library
    Affects Versions: 0.9
         Environment: Any big-endian system such as PPC Mac, Sparc, etc.
            Reporter: Andy Grundman
            Priority: Critical
         Attachments: perl-big-endian-double.patch

The code for handling doubles uses pack 'd' (pack to native byte order) and then reverses the bytes. This works on little-endian systems but will produce backwards data on big-endian systems.  Patch is attached.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1171) Perl write/readDouble assumes little-endian platform

Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell updated THRIFT-1171:
---------------------------------

    Affects Version/s:     (was: 0.9)
                       0.7

> Perl write/readDouble assumes little-endian platform
> ----------------------------------------------------
>
>                 Key: THRIFT-1171
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1171
>             Project: Thrift
>          Issue Type: Bug
>          Components: Perl - Library
>    Affects Versions: 0.7
>         Environment: Any big-endian system such as PPC Mac, Sparc, etc.
>            Reporter: Andy Grundman
>            Priority: Critical
>              Labels: patch
>             Fix For: 0.7
>
>         Attachments: perl-big-endian-double.patch
>
>
> The code for handling doubles uses pack 'd' (pack to native byte order) and then reverses the bytes. This works on little-endian systems but will produce backwards data on big-endian systems.  Patch is attached.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (THRIFT-1171) Perl write/readDouble assumes little-endian platform

Posted by "Andy Grundman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andy Grundman updated THRIFT-1171:
----------------------------------

    Attachment: perl-big-endian-double.patch

Patch against trunk.

> Perl write/readDouble assumes little-endian platform
> ----------------------------------------------------
>
>                 Key: THRIFT-1171
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1171
>             Project: Thrift
>          Issue Type: Bug
>          Components: Perl - Library
>    Affects Versions: 0.9
>         Environment: Any big-endian system such as PPC Mac, Sparc, etc.
>            Reporter: Andy Grundman
>            Priority: Critical
>              Labels: patch
>         Attachments: perl-big-endian-double.patch
>
>
> The code for handling doubles uses pack 'd' (pack to native byte order) and then reverses the bytes. This works on little-endian systems but will produce backwards data on big-endian systems.  Patch is attached.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Closed] (THRIFT-1171) Perl write/readDouble assumes little-endian platform

Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jake Farrell closed THRIFT-1171.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.7
         Assignee: Andy Grundman

Applied to trunk, thanks for the patch

> Perl write/readDouble assumes little-endian platform
> ----------------------------------------------------
>
>                 Key: THRIFT-1171
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1171
>             Project: Thrift
>          Issue Type: Bug
>          Components: Perl - Library
>    Affects Versions: 0.7
>         Environment: Any big-endian system such as PPC Mac, Sparc, etc.
>            Reporter: Andy Grundman
>            Assignee: Andy Grundman
>            Priority: Critical
>              Labels: patch
>             Fix For: 0.7
>
>         Attachments: perl-big-endian-double.patch
>
>
> The code for handling doubles uses pack 'd' (pack to native byte order) and then reverses the bytes. This works on little-endian systems but will produce backwards data on big-endian systems.  Patch is attached.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (THRIFT-1171) Perl write/readDouble assumes little-endian platform

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/THRIFT-1171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13044009#comment-13044009 ] 

Hudson commented on THRIFT-1171:
--------------------------------

Integrated in Thrift #155 (See [https://builds.apache.org/hudson/job/Thrift/155/])
    Thrift-1171: Perl write/readDouble assumes little-endian platform
Client: perl
Patch: Andy Grundman

The code for handling doubles uses pack 'd' (pack to native byte order) and then reverses the bytes. This works on little-endian systems but will produce backwards data on big-endian systems.


> Perl write/readDouble assumes little-endian platform
> ----------------------------------------------------
>
>                 Key: THRIFT-1171
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1171
>             Project: Thrift
>          Issue Type: Bug
>          Components: Perl - Library
>    Affects Versions: 0.7
>         Environment: Any big-endian system such as PPC Mac, Sparc, etc.
>            Reporter: Andy Grundman
>            Assignee: Andy Grundman
>            Priority: Critical
>              Labels: patch
>             Fix For: 0.7
>
>         Attachments: perl-big-endian-double.patch
>
>
> The code for handling doubles uses pack 'd' (pack to native byte order) and then reverses the bytes. This works on little-endian systems but will produce backwards data on big-endian systems.  Patch is attached.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira