You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Tom White (JIRA)" <ji...@apache.org> on 2011/02/18 19:15:38 UTC
[jira] Created: (MAPREDUCE-2338) Deprecate field selection methods
on JobConf
Deprecate field selection methods on JobConf
--------------------------------------------
Key: MAPREDUCE-2338
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
Project: Hadoop Map/Reduce
Issue Type: Improvement
Reporter: Tom White
KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2338) Deprecate field selection methods
on JobConf
Posted by "OZAWA Tsuyoshi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
OZAWA Tsuyoshi updated MAPREDUCE-2338:
--------------------------------------
Attachment: MR2338.3.patch
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch, MR-2338.2.patch, MR2338.3.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-2338) Deprecate field selection
methods on JobConf
Posted by "James Warren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Warren reassigned MAPREDUCE-2338:
---------------------------------------
Assignee: James Warren (was: Doug Balog)
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2338) Deprecate field selection
methods on JobConf
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13271458#comment-13271458 ]
Hadoop QA commented on MAPREDUCE-2338:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12526158/MR2338.3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
-1 javadoc. The javadoc tool appears to have generated 1 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
-1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient:
org.apache.hadoop.mapred.lib.TestKeyFieldBasedComparator
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2372//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/2372//console
This message is automatically generated.
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch, MR-2338.2.patch, MR2338.3.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2338) Deprecate field selection methods
on JobConf
Posted by "James Warren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Warren updated MAPREDUCE-2338:
------------------------------------
Attachment: MR-2338.2.patch
changed deprecated methods in JobConf to call new methods in KeyFieldBasedPartitioner and KeyFieldBasedComparator
made all getters / setters in KeyFieldBasedPartitioner / KeyFieldBasedComparator static
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch, MR-2338.2.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2338) Deprecate field selection methods
on JobConf
Posted by "OZAWA Tsuyoshi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
OZAWA Tsuyoshi updated MAPREDUCE-2338:
--------------------------------------
Release Note: (was: MAPREDUCE-2338. Deprecate field selection methods on JobConf.)
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch, MR-2338.2.patch, MR2338.3.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2338) Deprecate field selection
methods on JobConf
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032551#comment-13032551 ]
Tom White commented on MAPREDUCE-2338:
--------------------------------------
Thanks for the patch, James. I think the deprecated methods should invoke the new ones, to avoid code duplication. Also, there's a missing "static" on KeyFieldBasedComparator.getKeyFieldComparatorOption().
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2338) Deprecate field selection methods
on JobConf
Posted by "Sho Shimauchi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sho Shimauchi updated MAPREDUCE-2338:
-------------------------------------
Status: Open (was: Patch Available)
canceled patch since it's not been reviewed yet.
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch, MR-2338.2.patch, MR2338.3.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2338) Deprecate field selection
methods on JobConf
Posted by "OZAWA Tsuyoshi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272053#comment-13272053 ]
OZAWA Tsuyoshi commented on MAPREDUCE-2338:
-------------------------------------------
I'm sorry for my making a mistake about JIRA system.
James haven't worked this problem for a long time(one year), so I threw this patch to fix this problem.
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch, MR-2338.2.patch, MR2338.3.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2338) Deprecate field selection methods
on JobConf
Posted by "OZAWA Tsuyoshi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
OZAWA Tsuyoshi updated MAPREDUCE-2338:
--------------------------------------
Release Note: MAPREDUCE-2338. Deprecate field selection methods on JobConf.
Hadoop Flags: (was: Reviewed)
Status: Patch Available (was: Open)
I fixed MR-2338.2.patch to fit the current directory structure. Please check it out.
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch, MR-2338.2.patch, MR2338.3.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2338) Deprecate field selection methods
on JobConf
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated MAPREDUCE-2338:
-------------------------------------
Status: Open (was: Patch Available)
Sorry to come in late, the patch has gone stale. Can you please rebase? Thanks.
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch, MR-2338.2.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2338) Deprecate field selection
methods on JobConf
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13035656#comment-13035656 ]
Hadoop QA commented on MAPREDUCE-2338:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12479068/MR-2338.2.patch
against trunk revision 1104687.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/267//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/267//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/267//console
This message is automatically generated.
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch, MR-2338.2.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2338) Deprecate field selection methods
on JobConf
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-2338:
---------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
+1
I'm marking this as Patch Available so that Jenkins runs the tests for it.
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch, MR-2338.2.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (MAPREDUCE-2338) Deprecate field selection
methods on JobConf
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon reassigned MAPREDUCE-2338:
--------------------------------------
Assignee: Doug Balog
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: Doug Balog
> Labels: newbie
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2338) Deprecate field selection methods
on JobConf
Posted by "James Warren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Warren updated MAPREDUCE-2338:
------------------------------------
Attachment: MR-2338.1.patch
moved KeyFieldBasedComparator and KeyFieldBasedPartitioner getters / setters from JobConf to static methods in respective classes; updated corresponding unit test
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2338) Deprecate field selection
methods on JobConf
Posted by "James Warren (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13032554#comment-13032554 ]
James Warren commented on MAPREDUCE-2338:
-----------------------------------------
Thanks for the feedback, Tom - will make the changes and upload a new patch
later today.
cheers,
-James
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2338) Deprecate field selection methods
on JobConf
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated MAPREDUCE-2338:
---------------------------------
Tags: newbie
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2338) Deprecate field selection
methods on JobConf
Posted by "Harsh J (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404571#comment-13404571 ]
Harsh J commented on MAPREDUCE-2338:
------------------------------------
Tsuyoshi,
I've resolved MAPREDUCE-4253 for you (thanks!), and hopefully this can now proceed if it was blocked due to that.
> Deprecate field selection methods on JobConf
> --------------------------------------------
>
> Key: MAPREDUCE-2338
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2338
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Tom White
> Assignee: James Warren
> Labels: newbie
> Attachments: MR-2338.1.patch, MR-2338.2.patch, MR2338.3.patch
>
>
> KeyFieldBasedComparator and KeyFieldBasedPartitioner are libraries so should not appear as getters and setters in JobConf. For the new API there are getters and setters on KeyFieldBasedComparator and KeyFieldBasedPartitioner themselves - we should add the equivalent to the old API and deprecate the references in JobConf.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira