You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/13 03:36:13 UTC
[GitHub] [spark] warrenzhu25 opened a new pull request #35500: [SPARK-33274][SS] Stop query in cp mode when total cores less than total kafka partition
warrenzhu25 opened a new pull request #35500:
URL: https://github.com/apache/spark/pull/35500
### What changes were proposed in this pull request?
Add check for total executor cores when `SetReaderPartitions` message received.
### Why are the changes needed?
In continuous processing mode, EpochCoordinator won't add offsets to query until got ReportPartitionOffset from all partitions. Normally, each kafka topic partition will be handled by one core, if total cores is smaller than total kafka topic partition counts, the job will hang without any error message.
### Does this PR introduce _any_ user-facing change?
Yes, if total executor cores is smaller than total kafka partition count, the exception with below error will be thrown:
`Total %s (kafka partitions) * %s (cpus per task) = %s needed,
but only have %s (executors) * %s (cores per executor) = %s (total cores).
Please increase total number of executor cores to at least %s.`
### How was this patch tested?
Added test in EpochCoordinatorSuite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35500: [SPARK-33274][SS] Stop query in cp mode when total cores less than total kafka partition
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35500:
URL: https://github.com/apache/spark/pull/35500#issuecomment-1038816176
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org