You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Dennis Lundberg <de...@apache.org> on 2007/08/15 20:46:53 UTC

Re: svn commit: r565847 - in /commons/proper/configuration/trunk: build.xml pom.xml

javax.mail 1.4 is for Java 1.4 and upwards only.
Does configuration require Java 1.4?

oheger@apache.org wrote:
> Author: oheger
> Date: Tue Aug 14 10:59:46 2007
> New Revision: 565847
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=565847
> Log:
> Added missing dependency to javax.mail to maven 2 and ant build
> 
> Modified:
>     commons/proper/configuration/trunk/build.xml
>     commons/proper/configuration/trunk/pom.xml
> 
> Modified: commons/proper/configuration/trunk/build.xml
> URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/build.xml?view=diff&rev=565847&r1=565846&r2=565847
> ==============================================================================
> --- commons/proper/configuration/trunk/build.xml (original)
> +++ commons/proper/configuration/trunk/build.xml Tue Aug 14 10:59:46 2007
> @@ -274,6 +274,8 @@
>      </get>
>      <get dest="${libdir}/maven-findbugs-plugin-0.8.4.jar" usetimestamp="true" ignoreerrors="true" src="http://www.ibiblio.org/maven/maven-plugins/plugins/maven-findbugs-plugin-0.8.4.jar">
>      </get>
> +    <get dest="${libdir}/mail-1.4.jar" usetimestamp="true" ignoreerrors="true" src="http://repo1.maven.org/maven2/javax/mail/mail/1.4/mail-1.4.jar">
> +    </get>
>    </target>
>    <target name="install-maven">
>      <get dest="${user.home}/maven-install-latest.jar" usetimestamp="true" src="${repo}/maven/maven-install-latest.jar">
> 
> Modified: commons/proper/configuration/trunk/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/configuration/trunk/pom.xml?view=diff&rev=565847&r1=565846&r2=565847
> ==============================================================================
> --- commons/proper/configuration/trunk/pom.xml (original)
> +++ commons/proper/configuration/trunk/pom.xml Tue Aug 14 10:59:46 2007
> @@ -317,6 +317,13 @@
>        <version>0.09</version>
>        <scope>test</scope>
>      </dependency>
> +
> +    <dependency>
> +      <groupId>javax.mail</groupId>
> +      <artifactId>mail</artifactId>
> +      <version>1.4</version>
> +      <scope>test</scope>
> +    </dependency>
>    </dependencies>
>  
>    <build>
> 
> 
> 


-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r565847 - in /commons/proper/configuration/trunk: build.xml pom.xml

Posted by Dennis Lundberg <de...@apache.org>.
Oliver Heger wrote:
> Dennis Lundberg wrote:
>> javax.mail 1.4 is for Java 1.4 and upwards only.
>> Does configuration require Java 1.4?
> 
> Good catch.
> 
> Indeed configuration should still work with 1.3.
> 
> Emmanuel modified the tests that require this dependency so that they
> only run on a JDK 1.4+. I use to run my (maven 1) build on a JDK 1.3 and
> thus could verify that this approach works.

Then the Maven 1 project.ml should prevent that particular test from 
being run. If that is already the case, then it should work.

> Thanks.
> Oliver
> 
>> oheger@apache.org wrote:
>>
>>> Author: oheger
>>> Date: Tue Aug 14 10:59:46 2007
>>> New Revision: 565847
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=565847
>>> Log:
>>> Added missing dependency to javax.mail to maven 2 and ant build
>>>
>>> Modified:
>>>     commons/proper/configuration/trunk/build.xml
>>>     commons/proper/configuration/trunk/pom.xml
>>>
>>> Modified: commons/proper/configuration/trunk/build.xml
>>> URL:
>>> http://svn.apache.org/viewvc/commons/proper/configuration/trunk/build.xml?view=diff&rev=565847&r1=565846&r2=565847
>>>
>>> ==============================================================================
>>>
>>> --- commons/proper/configuration/trunk/build.xml (original)
>>> +++ commons/proper/configuration/trunk/build.xml Tue Aug 14 10:59:46 2007
>>> @@ -274,6 +274,8 @@
>>>      </get>
>>>      <get dest="${libdir}/maven-findbugs-plugin-0.8.4.jar"
>>> usetimestamp="true" ignoreerrors="true"
>>> src="http://www.ibiblio.org/maven/maven-plugins/plugins/maven-findbugs-plugin-0.8.4.jar">
>>>
>>>      </get>
>>> +    <get dest="${libdir}/mail-1.4.jar" usetimestamp="true"
>>> ignoreerrors="true"
>>> src="http://repo1.maven.org/maven2/javax/mail/mail/1.4/mail-1.4.jar">
>>> +    </get>
>>>    </target>
>>>    <target name="install-maven">
>>>      <get dest="${user.home}/maven-install-latest.jar"
>>> usetimestamp="true" src="${repo}/maven/maven-install-latest.jar">
>>>
>>> Modified: commons/proper/configuration/trunk/pom.xml
>>> URL:
>>> http://svn.apache.org/viewvc/commons/proper/configuration/trunk/pom.xml?view=diff&rev=565847&r1=565846&r2=565847
>>>
>>> ==============================================================================
>>>
>>> --- commons/proper/configuration/trunk/pom.xml (original)
>>> +++ commons/proper/configuration/trunk/pom.xml Tue Aug 14 10:59:46 2007
>>> @@ -317,6 +317,13 @@
>>>        <version>0.09</version>
>>>        <scope>test</scope>
>>>      </dependency>
>>> +
>>> +    <dependency>
>>> +      <groupId>javax.mail</groupId>
>>> +      <artifactId>mail</artifactId>
>>> +      <version>1.4</version>
>>> +      <scope>test</scope>
>>> +    </dependency>
>>>    </dependencies>
>>>  
>>>    <build>
>>>
>>>
>>>
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
> 
> 


-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Re: svn commit: r565847 - in /commons/proper/configuration/trunk: build.xml pom.xml

Posted by Oliver Heger <ol...@oliver-heger.de>.
Dennis Lundberg wrote:
> javax.mail 1.4 is for Java 1.4 and upwards only.
> Does configuration require Java 1.4?

Good catch.

Indeed configuration should still work with 1.3.

Emmanuel modified the tests that require this dependency so that they
only run on a JDK 1.4+. I use to run my (maven 1) build on a JDK 1.3 and
thus could verify that this approach works.

Thanks.
Oliver

> 
> oheger@apache.org wrote:
> 
>> Author: oheger
>> Date: Tue Aug 14 10:59:46 2007
>> New Revision: 565847
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=565847
>> Log:
>> Added missing dependency to javax.mail to maven 2 and ant build
>>
>> Modified:
>>     commons/proper/configuration/trunk/build.xml
>>     commons/proper/configuration/trunk/pom.xml
>>
>> Modified: commons/proper/configuration/trunk/build.xml
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/configuration/trunk/build.xml?view=diff&rev=565847&r1=565846&r2=565847
>>
>> ==============================================================================
>>
>> --- commons/proper/configuration/trunk/build.xml (original)
>> +++ commons/proper/configuration/trunk/build.xml Tue Aug 14 10:59:46 2007
>> @@ -274,6 +274,8 @@
>>      </get>
>>      <get dest="${libdir}/maven-findbugs-plugin-0.8.4.jar"
>> usetimestamp="true" ignoreerrors="true"
>> src="http://www.ibiblio.org/maven/maven-plugins/plugins/maven-findbugs-plugin-0.8.4.jar">
>>
>>      </get>
>> +    <get dest="${libdir}/mail-1.4.jar" usetimestamp="true"
>> ignoreerrors="true"
>> src="http://repo1.maven.org/maven2/javax/mail/mail/1.4/mail-1.4.jar">
>> +    </get>
>>    </target>
>>    <target name="install-maven">
>>      <get dest="${user.home}/maven-install-latest.jar"
>> usetimestamp="true" src="${repo}/maven/maven-install-latest.jar">
>>
>> Modified: commons/proper/configuration/trunk/pom.xml
>> URL:
>> http://svn.apache.org/viewvc/commons/proper/configuration/trunk/pom.xml?view=diff&rev=565847&r1=565846&r2=565847
>>
>> ==============================================================================
>>
>> --- commons/proper/configuration/trunk/pom.xml (original)
>> +++ commons/proper/configuration/trunk/pom.xml Tue Aug 14 10:59:46 2007
>> @@ -317,6 +317,13 @@
>>        <version>0.09</version>
>>        <scope>test</scope>
>>      </dependency>
>> +
>> +    <dependency>
>> +      <groupId>javax.mail</groupId>
>> +      <artifactId>mail</artifactId>
>> +      <version>1.4</version>
>> +      <scope>test</scope>
>> +    </dependency>
>>    </dependencies>
>>  
>>    <build>
>>
>>
>>
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org