You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Diwaker Gupta (JIRA)" <ji...@apache.org> on 2011/07/06 01:40:16 UTC
[jira] [Created] (THRIFT-1231) Remove bogus include
Remove bogus include
--------------------
Key: THRIFT-1231
URL: https://issues.apache.org/jira/browse/THRIFT-1231
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.6.1
Environment: Ubuntu 11.04, latest trunk
Reporter: Diwaker Gupta
Priority: Minor
Fix For: 0.7
Attachments: THRIFT-1231.patch
TAsyncChannel.h includes TTransportUtils.h, but doesn't really need/use it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (THRIFT-1231) Remove bogus include
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jake Farrell closed THRIFT-1231.
--------------------------------
Resolution: Fixed
Assignee: Diwaker Gupta
Committed, Thanks for the patch.
> Remove bogus include
> --------------------
>
> Key: THRIFT-1231
> URL: https://issues.apache.org/jira/browse/THRIFT-1231
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.6.1
> Environment: Ubuntu 11.04, latest trunk
> Reporter: Diwaker Gupta
> Assignee: Diwaker Gupta
> Priority: Minor
> Fix For: 0.7
>
> Attachments: THRIFT-1231.patch
>
>
> TAsyncChannel.h includes TTransportUtils.h, but doesn't really need/use it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1231) Remove bogus include
Posted by "Diwaker Gupta (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Diwaker Gupta updated THRIFT-1231:
----------------------------------
Attachment: THRIFT-1231.patch
> Remove bogus include
> --------------------
>
> Key: THRIFT-1231
> URL: https://issues.apache.org/jira/browse/THRIFT-1231
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.6.1
> Environment: Ubuntu 11.04, latest trunk
> Reporter: Diwaker Gupta
> Priority: Minor
> Fix For: 0.7
>
> Attachments: THRIFT-1231.patch
>
>
> TAsyncChannel.h includes TTransportUtils.h, but doesn't really need/use it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1231) Remove bogus include
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062148#comment-13062148 ]
jiraposter@reviews.apache.org commented on THRIFT-1231:
-------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1023/
-----------------------------------------------------------
(Updated 2011-07-08 20:04:37.543693)
Review request for Thrift.
Changes
-------
Adding bug number for tracking.
Summary
-------
Remove bogus include.
TAsyncChannel includes TTransportUtils but doesn't need/use it.
This addresses bug THRIFT-1231.
https://issues.apache.org/jira/browse/THRIFT-1231
Diffs
-----
/lib/cpp/src/async/TAsyncChannel.h 1143615
Diff: https://reviews.apache.org/r/1023/diff
Testing
-------
make check in lib/cpp
Thanks,
Diwaker
> Remove bogus include
> --------------------
>
> Key: THRIFT-1231
> URL: https://issues.apache.org/jira/browse/THRIFT-1231
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.6.1
> Environment: Ubuntu 11.04, latest trunk
> Reporter: Diwaker Gupta
> Assignee: Diwaker Gupta
> Priority: Minor
> Fix For: 0.7
>
> Attachments: THRIFT-1231.patch
>
>
> TAsyncChannel.h includes TTransportUtils.h, but doesn't really need/use it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1231) Remove bogus include
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062099#comment-13062099 ]
Hudson commented on THRIFT-1231:
--------------------------------
Integrated in Thrift #188 (See [https://builds.apache.org/job/Thrift/188/])
THRIFT-1231: Remove bogus include
Client: c++
Patch: Diwaker Gupta
Removing unused import TTransportUtils.h from TAsyncChannel.h.
jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1144395
Files :
* /thrift/trunk/lib/cpp/src/async/TAsyncChannel.h
> Remove bogus include
> --------------------
>
> Key: THRIFT-1231
> URL: https://issues.apache.org/jira/browse/THRIFT-1231
> Project: Thrift
> Issue Type: Improvement
> Components: C++ - Library
> Affects Versions: 0.6.1
> Environment: Ubuntu 11.04, latest trunk
> Reporter: Diwaker Gupta
> Assignee: Diwaker Gupta
> Priority: Minor
> Fix For: 0.7
>
> Attachments: THRIFT-1231.patch
>
>
> TAsyncChannel.h includes TTransportUtils.h, but doesn't really need/use it.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira