You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Dave Brondsema (JIRA)" <de...@myfaces.apache.org> on 2006/02/24 23:58:58 UTC
[jira] Created: (MYFACES-1154)
PortletExternalContextImpl#encodeNamespace postfixes the namespace instead
of prefixes it
PortletExternalContextImpl#encodeNamespace postfixes the namespace instead of prefixes it
-----------------------------------------------------------------------------------------
Key: MYFACES-1154
URL: http://issues.apache.org/jira/browse/MYFACES-1154
Project: MyFaces Core
Type: Bug
Components: JSR-127
Versions: 1.1.2-SNAPSHOT
Reporter: Dave Brondsema
Priority: Trivial
PortletExternalContextImpl#encodeNamespace appends the namespace, whereas the specification requires that it prepend it
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1154)
PortletExternalContextImpl#encodeNamespace postfixes the namespace instead
of prefixes it
Posted by "Stan Silvert (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1154?page=comments#action_12367735 ]
Stan Silvert commented on MYFACES-1154:
---------------------------------------
It used to be implemented as per the spec. I don't know who changed it, but they added this comment:
//we render out the name and then the namespace as
// e.g. for JSF-ids, it is important to keep the _id prefix
//to know that id creation has happened automatically
Does anyone know if we need to keep it as-is?
> PortletExternalContextImpl#encodeNamespace postfixes the namespace instead of prefixes it
> -----------------------------------------------------------------------------------------
>
> Key: MYFACES-1154
> URL: http://issues.apache.org/jira/browse/MYFACES-1154
> Project: MyFaces Core
> Type: Bug
> Components: JSR-127
> Versions: 1.1.2-SNAPSHOT
> Reporter: Dave Brondsema
> Assignee: Stan Silvert
> Priority: Trivial
>
> PortletExternalContextImpl#encodeNamespace appends the namespace, whereas the specification requires that it prepend it
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1154)
PortletExternalContextImpl#encodeNamespace postfixes the namespace instead
of prefixes it
Posted by "Stan Silvert (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1154?page=comments#action_12367881 ]
Stan Silvert commented on MYFACES-1154:
---------------------------------------
I'm not sure if it really matters. I'll ask the EG to see if the RI developers mind if we change the spec to say "concatenate" instead of "prepend".
> PortletExternalContextImpl#encodeNamespace postfixes the namespace instead of prefixes it
> -----------------------------------------------------------------------------------------
>
> Key: MYFACES-1154
> URL: http://issues.apache.org/jira/browse/MYFACES-1154
> Project: MyFaces Core
> Type: Bug
> Components: JSR-127
> Versions: 1.1.2-SNAPSHOT
> Reporter: Dave Brondsema
> Assignee: Stan Silvert
> Priority: Trivial
>
> PortletExternalContextImpl#encodeNamespace appends the namespace, whereas the specification requires that it prepend it
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1154)
PortletExternalContextImpl#encodeNamespace postfixes the namespace instead
of prefixes it
Posted by "Henrik Bentel (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1154?page=comments#action_12367791 ]
Henrik Bentel commented on MYFACES-1154:
----------------------------------------
hi
Last fall I submitted a patch that appends the portlet namespace instead of prepend it.
Reason was that Myfaces would wrap elements in "span" tags if the ID didn't start with _ID.
Here's the issue link: http://issues.apache.org/jira/browse/MYFACES-702
I didn't see the section in the spec that requires prepending but if that is correct then a
different solution to MYFACES-702 should probably be found.
> PortletExternalContextImpl#encodeNamespace postfixes the namespace instead of prefixes it
> -----------------------------------------------------------------------------------------
>
> Key: MYFACES-1154
> URL: http://issues.apache.org/jira/browse/MYFACES-1154
> Project: MyFaces Core
> Type: Bug
> Components: JSR-127
> Versions: 1.1.2-SNAPSHOT
> Reporter: Dave Brondsema
> Assignee: Stan Silvert
> Priority: Trivial
>
> PortletExternalContextImpl#encodeNamespace appends the namespace, whereas the specification requires that it prepend it
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (MYFACES-1154)
PortletExternalContextImpl#encodeNamespace postfixes the namespace instead
of prefixes it
Posted by "Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>.
[ http://issues.apache.org/jira/browse/MYFACES-1154?page=comments#action_12439935 ]
Scott O'Bryan commented on MYFACES-1154:
----------------------------------------
JSR-168 says it can be either prepended OR appended in the spec (see API spec for RenderResponse.getNamespace(). I generally find perpending to be preferable but either should be fine for the spec purposes.
That being said, does anyone know why myfaces wraps elements that don't start with _ID? My personal preference would be to prepend the namespace and fix the issue of why these elements are getting wrapped. I mean this seems kinda wrong to me that the base implementation would muck with the output.
Scott
> PortletExternalContextImpl#encodeNamespace postfixes the namespace instead of prefixes it
> -----------------------------------------------------------------------------------------
>
> Key: MYFACES-1154
> URL: http://issues.apache.org/jira/browse/MYFACES-1154
> Project: MyFaces Core
> Issue Type: Bug
> Components: Portlet_Support
> Affects Versions: 1.1.2-SNAPSHOT
> Reporter: Dave Brondsema
> Assigned To: Stan Silvert
> Priority: Trivial
>
> PortletExternalContextImpl#encodeNamespace appends the namespace, whereas the specification requires that it prepend it
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira