You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/04/03 21:41:41 UTC
[jira] [Commented] (CB-12592) Refactor and add delete require.cache
to cordova_util and create pkgManager
[ https://issues.apache.org/jira/browse/CB-12592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954196#comment-15954196 ]
ASF GitHub Bot commented on CB-12592:
-------------------------------------
GitHub user audreyso opened a pull request:
https://github.com/apache/cordova-lib/pull/536
CB-12592 : Refactor and add delete require.cache to cordova_util and create packageManager to load and save files.
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
### What does this PR do?
Refactor and add delete require.cache to cordova_util and create packageManager to load and save files.
### What testing has been done on this change?
### Checklist
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [X] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/audreyso/cordova-lib CB-12592
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/536.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #536
----
commit 0e3e0a48b63c0534af4e4b7e2ec00233de86f534
Author: Audrey So <au...@apache.org>
Date: 2017-03-21T18:13:28Z
CB-12592 : added requireNoCache function and removed delete.require cache from cordova-lib
commit ff13fc834549c254937b66d3138a7adb22598316
Author: Audrey So <au...@apache.org>
Date: 2017-03-22T15:12:32Z
CB-12592 : updated and replaced instances of delete require cache
commit f8bce61c99c8c57bd3ba3ca348587d0edd962dfe
Author: Audrey So <au...@apache.org>
Date: 2017-03-30T22:44:17Z
CB-12592 : added packageManger to load and save pkgjson files and replace fs.write with packageManager
----
> Refactor and add delete require.cache to cordova_util and create pkgManager
> ---------------------------------------------------------------------------
>
> Key: CB-12592
> URL: https://issues.apache.org/jira/browse/CB-12592
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-lib
> Reporter: Audrey So
> Assignee: Audrey So
> Priority: Minor
> Labels: 7.0.0
>
> There are 120 instances of delete require.cache in cordova-lib. It should be refactored and added to cordova_util so it can be reused when needed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org