You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/08/26 07:26:12 UTC
[GitHub] [submarine] pingsutw opened a new pull request #722: SUBMARINE-922. Migrate to the next version of Python requests when released
pingsutw opened a new pull request #722:
URL: https://github.com/apache/submarine/pull/722
### What is this PR for?
<!-- A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
-->
See github issue: https://github.com/apache/submarine/issues/661
Our python code uses requests library which has transitive dependency on a GPL lib chardet.
We're not supposed to make an ASF release knowing there's a GPL transitive dependency so this is a blocker for our 0.6.0 release.
Quickly checked the code, we have two places that use the library. We could wait for the new requests or perhaps remove the usage.
```
find . -name "*.py" | xargs grep "import requests"
./submarine-sdk/pysubmarine/submarine/utils/rest_utils.py:import requests
./submarine-sdk/pysubmarine/build/lib/submarine/utils/rest_utils.py:import requests
```
### What type of PR is it?
[Hot Fix]
### Todos
No
### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
-->
https://issues.apache.org/jira/browse/SUBMARINE-922
### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
Pass the CIs
### Screenshots (if appropriate)
### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [submarine] asfgit closed pull request #722: SUBMARINE-922. Migrate to the next version of Python requests when released
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #722:
URL: https://github.com/apache/submarine/pull/722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org