You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/08/08 06:53:19 UTC
[GitHub] [pinot] xiangfu0 opened a new pull request, #11290: Fixing the flaky test TupleSketchIntegrationTest
xiangfu0 opened a new pull request, #11290:
URL: https://github.com/apache/pinot/pull/11290
The sketch bytes size can be 1740 or 1756.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on pull request #11290: [flaky tests]Fixing the flaky test TupleSketchIntegrationTest
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on PR #11290:
URL: https://github.com/apache/pinot/pull/11290#issuecomment-1670355510
Discussed offline. Currently we have one integration test per function to test the wiring of v2, which is not scalable and way too expensive. We should consolidate them into one test for all these queries. We can take this separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 merged pull request #11290: [flaky tests]Fixing the flaky test TupleSketchIntegrationTest
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 merged PR #11290:
URL: https://github.com/apache/pinot/pull/11290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #11290: [flaky tests]Fixing the flaky test TupleSketchIntegrationTest
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang commented on code in PR #11290:
URL: https://github.com/apache/pinot/pull/11290#discussion_r1287713626
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/TupleSketchIntegrationTest.java:
##########
@@ -96,7 +95,8 @@ public void testQueries(boolean useMultiStageQueryEngine)
DEFAULT_TABLE_NAME);
JsonNode jsonNode = postQuery(query);
assertTrue(jsonNode.get("resultTable").get("rows").get(0).get(0).asLong() > 0);
- assertEquals(jsonNode.get("resultTable").get("rows").get(0).get(1).asText().length(), 1756);
+ assertTrue((jsonNode.get("resultTable").get("rows").get(0).get(1).asText().length() == 1740) || (
Review Comment:
This test is too brutal, and not really verify anything..
For the raw tuple sketch, we should just deserialize it and verify if it returns the same distinct count as the first value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11290: Fixing the flaky test TupleSketchIntegrationTest
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11290:
URL: https://github.com/apache/pinot/pull/11290#issuecomment-1669066688
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11290?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11290](https://app.codecov.io/gh/apache/pinot/pull/11290?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (351f6c6) into [master](https://app.codecov.io/gh/apache/pinot/commit/a6e23c1f73e2867f6bc7f6cba76b70e83c49c354?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a6e23c1) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #11290 +/- ##
=========================================
Coverage 0.11% 0.11%
=========================================
Files 2230 2156 -74
Lines 120140 116983 -3157
Branches 18218 17772 -446
=========================================
Hits 137 137
+ Misses 119983 116826 -3157
Partials 20 20
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `0.11% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 76 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11290/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org