[GitHub] [ignite-3] denis-chudov commented on a diff in pull request #1908: IGNITE-19238

["denis-chudov (via GitHub)" <gi...@apache.org>]

denis-chudov commented on code in PR #1908:
URL: https://github.com/apache/ignite-3/pull/1908#discussion_r1159735496


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -995,13 +988,11 @@ public void stop() {
         metaStorageMgr.unregisterWatch(stableAssignmentsRebalanceListener);
         metaStorageMgr.unregisterWatch(assignmentsSwitchRebalanceListener);
 
-        Map<UUID, TableImpl> tables = tablesByIdVv.latest();
-
-        cleanUpTablesResources(tables);
+        Stream<TableImpl> tablesToStop =
+                Stream.concat(tablesByIdVv.latest().entrySet().stream(), pendingTables.entrySet().stream()).
+                        map(Map.Entry::getValue);

Review Comment:
   seems that `.distinct()` is needed if we want to process every table just once



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org