You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@mesosphere.io> on 2017/12/08 03:59:39 UTC
Review Request 64440: Added `MODIFY_RESOURCE_PROVIDER_CONFIG`
authorization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64440/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Joseph Wu.
Bugs: MESOS-8244
https://issues.apache.org/jira/browse/MESOS-8244
Repository: mesos
Description
-------
The new authorization is for authorizing `ADD_RESOURCE_PROVIDER_CONFIG`,
`UPDATE_RESOURCE_PROVIDER_CONFIG`, and `REMOVE_RESOURCE_PROVIDER_CONFIG`
agent API calls.
Diffs
-----
include/mesos/authorizer/acls.proto 6f36470091929006e7a403b7d652e4d11a226b22
include/mesos/authorizer/authorizer.proto d84295fad90815fcdb851f9c917384d7002bd985
src/authorizer/local/authorizer.cpp e07f57eb99b03eb470955350f757dcffe1f03238
Diff: https://reviews.apache.org/r/64440/diff/1/
Testing
-------
Thanks,
Chun-Hung Hsiao
Re: Review Request 64440: Added `MODIFY_RESOURCE_PROVIDER_CONFIG`
authorization.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64440/#review193311
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 8, 2017, 3:59 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64440/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 3:59 a.m.)
>
>
> Review request for mesos, Jie Yu and Joseph Wu.
>
>
> Bugs: MESOS-8244
> https://issues.apache.org/jira/browse/MESOS-8244
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new authorization is for authorizing `ADD_RESOURCE_PROVIDER_CONFIG`,
> `UPDATE_RESOURCE_PROVIDER_CONFIG`, and `REMOVE_RESOURCE_PROVIDER_CONFIG`
> agent API calls.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/acls.proto 6f36470091929006e7a403b7d652e4d11a226b22
> include/mesos/authorizer/authorizer.proto d84295fad90815fcdb851f9c917384d7002bd985
> src/authorizer/local/authorizer.cpp e07f57eb99b03eb470955350f757dcffe1f03238
>
>
> Diff: https://reviews.apache.org/r/64440/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 64440: Added `MODIFY_RESOURCE_PROVIDER_CONFIG`
authorization.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64440/#review193222
-----------------------------------------------------------
please add some unit test
- Jie Yu
On Dec. 8, 2017, 3:59 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64440/
> -----------------------------------------------------------
>
> (Updated Dec. 8, 2017, 3:59 a.m.)
>
>
> Review request for mesos, Jie Yu and Joseph Wu.
>
>
> Bugs: MESOS-8244
> https://issues.apache.org/jira/browse/MESOS-8244
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The new authorization is for authorizing `ADD_RESOURCE_PROVIDER_CONFIG`,
> `UPDATE_RESOURCE_PROVIDER_CONFIG`, and `REMOVE_RESOURCE_PROVIDER_CONFIG`
> agent API calls.
>
>
> Diffs
> -----
>
> include/mesos/authorizer/acls.proto 6f36470091929006e7a403b7d652e4d11a226b22
> include/mesos/authorizer/authorizer.proto d84295fad90815fcdb851f9c917384d7002bd985
> src/authorizer/local/authorizer.cpp e07f57eb99b03eb470955350f757dcffe1f03238
>
>
> Diff: https://reviews.apache.org/r/64440/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>