You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "bricefrisco (via GitHub)" <gi...@apache.org> on 2023/03/15 14:40:02 UTC
[GitHub] [camel] bricefrisco opened a new pull request, #9546: CAMEL-19143: Added option to quote fields only when necessary
bricefrisco opened a new pull request, #9546:
URL: https://github.com/apache/camel/pull/9546
# Description
<!--
- Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
-->
Implements [CAMEL-19143](https://issues.apache.org/jira/browse/CAMEL-19143)
The `quoting` option of the camel-bindy component enables quoting of all fields. This option provides the ability to quote fields only when it is necessary.
According to [RFC 4180 2.6](https://www.ietf.org/rfc/rfc4180.txt):
> 6. Fields containing line breaks (CRLF), double quotes, and commas
> should be enclosed in double-quotes. For example:
> "aaa","b CRLF
> bb","ccc" CRLF
> zzz,yyy,xxx
This option enables quoting a field **if and only if** that field:
contains the configured `crlf` character OR
contains the configured `quote` character OR
contains the configured `separator` character
# Target
- [X] I checked that the commit is targeting the correct branch (note that Camel 3 uses `camel-3.x`, whereas Camel 4 uses the `main` branch)
# Tracking
- [X] If this is a large change, bug fix, or code improvement, I checked there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).
<!--
# *Note*: trivial changes like, typos, minor documentation fixes and other small items do not require a JIRA issue. In this case your pull request should address just this issue, without pulling in other changes.
-->
# Apache Camel coding standards and style
- [X] I checked that each commit in the pull request has a meaningful subject line and body.
<!--
If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
-->
- [X] I formatted the code using `mvn -Pformat,fastinstall install && mvn -Psourcecheck`
<!--
You can run the aforementioned command in your module so that the build auto-formats your code and the source check verifies that is complies with our coding style. This will also be verified as part of the checks and your PR may be rejected if the checkstyle does not pass.
You can learn more about the contribution guidelines at https://github.com/apache/camel/blob/main/CONTRIBUTING.md
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bricefrisco commented on pull request #9546: CAMEL-19143: Added option to quote fields only when necessary
Posted by "bricefrisco (via GitHub)" <gi...@apache.org>.
bricefrisco commented on PR #9546:
URL: https://github.com/apache/camel/pull/9546#issuecomment-1470415945
I am not sure what is wrong with `checkstyle` and `build`, these commands are passing for me:
```
mvn clean install -Psourcecheck
mvn clean install
```
If there is something I have missed please let me know :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] bricefrisco commented on pull request #9546: CAMEL-19143: Added option to quote fields only when necessary
Posted by "bricefrisco (via GitHub)" <gi...@apache.org>.
bricefrisco commented on PR #9546:
URL: https://github.com/apache/camel/pull/9546#issuecomment-1470445315
> I think this needs to go on main too
Ok, I have created https://github.com/apache/camel/pull/9552 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9546: CAMEL-19143: Added option to quote fields only when necessary
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9546:
URL: https://github.com/apache/camel/pull/9546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9546: CAMEL-19143: Added option to quote fields only when necessary
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9546:
URL: https://github.com/apache/camel/pull/9546#issuecomment-1470130555
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:warning: Please note that the changes on this PR may be **tested automatically**.
If necessary Apache Camel Committers may access logs and test results in the job summaries!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org