[GitHub] [tvm] AndrewZhaoLuo commented on a change in pull request #9303: [Keras] Support return_sequences in LSTM

[GitBox <gi...@apache.org>]

AndrewZhaoLuo commented on a change in pull request #9303:
URL: https://github.com/apache/tvm/pull/9303#discussion_r731369633



##########
File path: tests/python/frontend/keras/test_forward.py
##########
@@ -417,12 +417,20 @@ def test_forward_reuse_layers(self, keras):
         keras_model = keras.models.Model(data, z)
         verify_keras_frontend(keras_model)
 
+    def test_forward_lstm(self, keras):
+        data = keras.layers.Input(shape=(10, 32))
+        rnn_funcs = [
+            keras.layers.LSTM(16),
+            keras.layers.LSTM(16, return_sequences=True),
+        ]
+        for rnn_func in rnn_funcs:
+            x = rnn_func(data)
+            keras_model = keras.models.Model(data, x)
+            verify_keras_frontend(keras_model, need_transpose=False)
+
     def test_forward_rnn(self, keras):
         data = keras.layers.Input(shape=(1, 32))
         rnn_funcs = [
-            keras.layers.LSTM(

Review comment:
       i would keep this test here for completeness and make the above only testing the return_sequence flag.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org