You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/01 08:39:11 UTC
[jira] [Commented] (FLINK-4127) Clean up configuration and check
breaking API changes
[ https://issues.apache.org/jira/browse/FLINK-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15358664#comment-15358664 ]
ASF GitHub Bot commented on FLINK-4127:
---------------------------------------
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/2177#discussion_r69267193
--- Diff: flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java ---
@@ -269,26 +269,26 @@
* Percentage of heap space to remove from containers (YARN / Mesos), to compensate
* for other JVM memory usage.
*/
- public static final String CONTAINERED_HEAP_CUTOFF_RATIO = "containered.heap-cutoff-ratio";
+ public static final String CONTAINER_HEAP_CUTOFF_RATIO = "container.heap-cutoff-ratio";
/**
* Minimum amount of heap memory to remove in containers, as a safety margin.
*/
- public static final String CONTAINERED_HEAP_CUTOFF_MIN = "containered.heap-cutoff-min";
+ public static final String CONTAINER_HEAP_CUTOFF_MIN = "container.heap-cutoff-min";
/**
* Prefix for passing custom environment variables to Flink's master process.
* For example for passing LD_LIBRARY_PATH as an env variable to the AppMaster, set:
* yarn.application-master.env.LD_LIBRARY_PATH: "/usr/lib/native"
* in the flink-conf.yaml.
*/
- public static final String CONTAINERED_MASTER_ENV_PREFIX = "containered.application-master.env.";
+ public static final String CONTAINER_MASTER_ENV_PREFIX = "container.application-master.env.";
/**
- * Similar to the {@see CONTAINERED_MASTER_ENV_PREFIX}, this configuration prefix allows
+ * Similar to the {@see CONTAINER_MASTER_ENV_PREFIX}, this configuration prefix allows
* setting custom environment variables for the workers (TaskManagers)
*/
- public static final String CONTAINERED_TASK_MANAGER_ENV_PREFIX = "containered.taskmanager.env.";
+ public static final String CONTAINER_TASK_MANAGER_ENV_PREFIX = "container.taskmanager.env.";
--- End diff --
Actually, I'm not so sure about this anymore, because it taskManager is a name used in the documentation everywhere. Maybe we keep this name here?
> Clean up configuration and check breaking API changes
> -----------------------------------------------------
>
> Key: FLINK-4127
> URL: https://issues.apache.org/jira/browse/FLINK-4127
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: Robert Metzger
> Assignee: Robert Metzger
> Fix For: 1.1.0
>
> Attachments: flink-core.html, flink-java.html, flink-scala.html, flink-streaming-java.html, flink-streaming-scala.html
>
>
> For the upcoming 1.1. release, I'll check if there are any breaking API changes and if the documentation is up tp date with the configuration.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)