You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/23 04:16:57 UTC
[GitHub] [flink-table-store] SteNicholas opened a new pull request, #398: [FLINK-30110] Enable from-timestamp log scan when timestamp-millis is configured
SteNicholas opened a new pull request, #398:
URL: https://github.com/apache/flink-table-store/pull/398
When `log.scan.timestamp-millis` is configured and `log.scan` isn't configured, the `log.scan` should be setting to `from-timestamp` by default.
**The brief change log**
- `FileStoreTableFactory#validateOptions` should validate the case that `log.scan.timestamp-millis` is configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi commented on pull request #398: [FLINK-30110] Enable from-timestamp log scan when timestamp-millis is configured
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on PR #398:
URL: https://github.com/apache/flink-table-store/pull/398#issuecomment-1325910438
Hi @SteNicholas Can you rebase the latest master? I think we can just set `log.scan` now, there is a safe `validate` method now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #398: [FLINK-30110] Enable from-timestamp log scan when timestamp-millis is configured
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #398:
URL: https://github.com/apache/flink-table-store/pull/398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] SteNicholas commented on pull request #398: [FLINK-30110] Enable from-timestamp log scan when timestamp-millis is configured
Posted by GitBox <gi...@apache.org>.
SteNicholas commented on PR #398:
URL: https://github.com/apache/flink-table-store/pull/398#issuecomment-1333137959
@JingsongLi, I have rebased the master branch and addressed above comments. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org