You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/14 06:15:15 UTC
[GitHub] [bookkeeper] lhotari opened a new issue #3104: Recycled LedgerEntryImpl instances are corrupted due to a thread safety issue in BK client
lhotari opened a new issue #3104:
URL: https://github.com/apache/bookkeeper/issues/3104
**BUG REPORT**
***Describe the bug***
See https://github.com/apache/pulsar/issues/14436#issuecomment-1064758710 for a detailed analysis by @congbobo184 about the symptoms of the thread safety issue.
It looks like it is caused by the changes in PR #1792. The change breaks thread safety for PendingReadOp handling which doesn't have any synchronization on it's own. The design seems to rely on the fact that the request is created by the same thread that handles the response. Before PR #1792 that was the case.
A network request-response call doesn't ensure happens-before and a separate solution for ensuring that would be needed unless PR#1792 is reverted. Happens-before visibility guarantee is needed since there's no synchronization in the PendingReadOp handling.
***To Reproduce***
Steps to reproduce the behavior:
Follow instructions in https://github.com/apache/pulsar/issues/14436
***Expected behavior***
BK client should not contain thread safety issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on issue #3104: Recycled LedgerEntryImpl instances are corrupted due to a thread safety issue in BK client
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #3104:
URL: https://github.com/apache/bookkeeper/issues/3104#issuecomment-1066474503
PR for the revert:
https://github.com/apache/bookkeeper/pull/3106
great work @lhotari @congbo1984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] lhotari commented on issue #3104: Recycled LedgerEntryImpl instances are corrupted due to invalid state handling in BK client
Posted by GitBox <gi...@apache.org>.
lhotari commented on issue #3104:
URL: https://github.com/apache/bookkeeper/issues/3104#issuecomment-1068108570
This will be fixed by #3110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli edited a comment on issue #3104: Recycled LedgerEntryImpl instances are corrupted due to a thread safety issue in BK client
Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on issue #3104:
URL: https://github.com/apache/bookkeeper/issues/3104#issuecomment-1066474503
PR for the revert:
https://github.com/apache/bookkeeper/pull/3106
great work @lhotari @congbobo1984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli edited a comment on issue #3104: Recycled LedgerEntryImpl instances are corrupted due to a thread safety issue in BK client
Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on issue #3104:
URL: https://github.com/apache/bookkeeper/issues/3104#issuecomment-1066472346
Makes sense to me.
I am fine with reverting #1792
data corruption is a bad problem, "being faster" is only an enhancement.
we should revert that change on master branch and on other active branches and possibly cut a new release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on issue #3104: Recycled LedgerEntryImpl instances are corrupted due to a thread safety issue in BK client
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #3104:
URL: https://github.com/apache/bookkeeper/issues/3104#issuecomment-1066472346
Makes sense to me.
I am fine with reverting #3105
data corruption is a bad problem, "being faster" is only an enhancement.
we should revert that change on master branch and on other active branches and possibly cut a new release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org