You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/24 02:09:21 UTC

[GitHub] [iotdb] JackieTien97 opened a new pull request #4960: Make FileTimeIndex directly return true while doing containsDevice()

JackieTien97 opened a new pull request #4960:
URL: https://github.com/apache/iotdb/pull/4960


   * While one TsFileResouece's ITimeIndex degrade from DeviceTimeIndex to FileTimeIndex, each time a query arrived, it will read from tsfile to judge whether this tsfile contains current device. However, this is totally unnecessary. We can simply return true here, and then do this judgement in the following query process, while getting the TimeseriesMetadata, it can also use the bloomfilter in tsfile footer to accelerate this process.
   
   * Encapsulate the process of opening and releasing file handles into `FileReaderManager`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4960: Make FileTimeIndex directly return true while doing containsDevice()

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4960:
URL: https://github.com/apache/iotdb/pull/4960#issuecomment-1019671693


   
   [![Coverage Status](https://coveralls.io/builds/45864411/badge)](https://coveralls.io/builds/45864411)
   
   Coverage decreased (-0.02%) to 67.711% when pulling **cefcf1856aa59c49bd640c28da61c7aa2a096db9 on FileTimeIndex** into **4e87d43d0bd18b30f96db9745bdef89c6ee1f4c1 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #4960: Make FileTimeIndex directly return true while doing containsDevice()

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4960:
URL: https://github.com/apache/iotdb/pull/4960#issuecomment-1019684941


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4960&resolved=false&types=CODE_SMELL)
   
   [![63.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '63.2%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4960&metric=new_coverage&view=list) [63.2% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4960&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4960&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4960&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] qiaojialin merged pull request #4960: Make FileTimeIndex directly return true while doing containsDevice()

Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #4960:
URL: https://github.com/apache/iotdb/pull/4960


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4960: Make FileTimeIndex directly return true while doing containsDevice()

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4960:
URL: https://github.com/apache/iotdb/pull/4960#issuecomment-1019671693


   
   [![Coverage Status](https://coveralls.io/builds/45864121/badge)](https://coveralls.io/builds/45864121)
   
   Coverage decreased (-0.01%) to 67.723% when pulling **cefcf1856aa59c49bd640c28da61c7aa2a096db9 on FileTimeIndex** into **4e87d43d0bd18b30f96db9745bdef89c6ee1f4c1 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org