You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/10/26 00:31:57 UTC
Review Request 14952: Making the constructor of Shared explicit.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14952/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
Repository: mesos-git
Description
-------
See title. Make sure we don't accidentally do the following:
void func(const Shared<Foo>& foo) {...}
Foo* foo = new Foo();
func(foo);
delete foo;
Diffs
-----
3rdparty/libprocess/include/process/shared.hpp faa11cc
Diff: https://reviews.apache.org/r/14952/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 14952: Making the constructor of Shared explicit.
Posted by Jie Yu <yu...@gmail.com>.
Discarded.
On Thu, Oct 31, 2013 at 11:51 AM, Ben Mahler <be...@gmail.com>wrote:
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14952/
>
> Has this been obviated by your new review?https://reviews.apache.org/r/15112
>
>
> - Ben Mahler
>
> On October 25th, 2013, 10:31 p.m. UTC, Jie Yu wrote:
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
> By Jie Yu.
>
> *Updated Oct. 25, 2013, 10:31 p.m.*
> *Repository: * mesos-git
> Description
>
> See title. Make sure we don't accidentally do the following:
>
> void func(const Shared<Foo>& foo) {...}
>
> Foo* foo = new Foo();
> func(foo);
> delete foo;
>
> Testing
>
> make check
>
> Diffs
>
> - 3rdparty/libprocess/include/process/shared.hpp (faa11cc)
>
> View Diff <https://reviews.apache.org/r/14952/diff/>
>
Re: Review Request 14952: Making the constructor of Shared explicit.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14952/#review27937
-----------------------------------------------------------
Has this been obviated by your new review?
https://reviews.apache.org/r/15112
- Ben Mahler
On Oct. 25, 2013, 10:31 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14952/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2013, 10:31 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See title. Make sure we don't accidentally do the following:
>
> void func(const Shared<Foo>& foo) {...}
>
> Foo* foo = new Foo();
> func(foo);
> delete foo;
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/shared.hpp faa11cc
>
> Diff: https://reviews.apache.org/r/14952/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>