You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@olingo.apache.org by "Christian Amend (JIRA)" <ji...@apache.org> on 2014/09/23 14:57:33 UTC

[jira] [Assigned] (OLINGO-436) Code duplication batch request

     [ https://issues.apache.org/jira/browse/OLINGO-436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Christian Amend reassigned OLINGO-436:
--------------------------------------

    Assignee: Christian Amend

I have created a branch for the given diff file. I will look at it later.

> Code duplication batch request
> ------------------------------
>
>                 Key: OLINGO-436
>                 URL: https://issues.apache.org/jira/browse/OLINGO-436
>             Project: Olingo
>          Issue Type: Improvement
>          Components: odata2-core
>    Affects Versions: V2 2.0.1
>            Reporter: Christian Holzer
>            Assignee: Christian Amend
>            Priority: Minor
>              Labels: batch, parser
>         Attachments: batchRebase.diff
>
>
> Within the batch parser exists some duplicated code. The duplication is based on the same structure of the batch request and the batch response. So I would like to suggest a refactoring to create a common basis for batch requests and responses, also. 
> In my opinion the parsing could be split up in two parts.  The common part could parse the syntactic structure of a batch message. Based on the type of message, a suitable semantic parser will be chosen. The semantic parser validates the input and creates the necessary ODataRequests or ODataSingleResponses.
>  
> I attached a patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)