You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/22 02:32:57 UTC
[GitHub] [ozone] sky76093016 opened a new pull request #2761: HDDS-5888. Handle InterruptedException in OzoneClientProducer and ContainerBalancer
sky76093016 opened a new pull request #2761:
URL: https://github.com/apache/ozone/pull/2761
## What changes were proposed in this pull request?
As described in [HDDS-5434](https://github.com/apache/ozone/pull/2413).
## What is the link to the Apache JIRA
https://issues.apache.org/jira/projects/HDDS/issues/HDDS-5888
## How was this patch tested?
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on pull request #2761: HDDS-5888. Handle InterruptedException in OzoneClientProducer and ContainerBalancer
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on pull request #2761:
URL: https://github.com/apache/ozone/pull/2761#issuecomment-949237943
@jojochuang Please take a look.Thanks~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on a change in pull request #2761: HDDS-5888. Handle InterruptedException in OzoneClientProducer and ContainerBalancer
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #2761:
URL: https://github.com/apache/ozone/pull/2761#discussion_r734326206
##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java
##########
@@ -137,6 +137,11 @@ private OzoneClient getClient(OzoneConfiguration config)
LOG.debug("Error during Client Creation: ", ex);
}
throw wrapOS3Exception(ex);
+ } catch(InterruptedException ex){
+ if (LOG.isDebugEnabled()) {
Review comment:
we can simplify the logging since it's slf4j. Not need to check isDebugEnabled()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2761: HDDS-5888. Handle InterruptedException in OzoneClientProducer and ContainerBalancer
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2761:
URL: https://github.com/apache/ozone/pull/2761#discussion_r734327659
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -783,6 +784,7 @@ public void stop() {
try {
currentBalancingThread.join();
} catch (InterruptedException ignored) {
Review comment:
Thanks to @siddhantsangwan for reviewing, I will correct it as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sky76093016 commented on a change in pull request #2761: HDDS-5888. Handle InterruptedException in OzoneClientProducer and ContainerBalancer
Posted by GitBox <gi...@apache.org>.
sky76093016 commented on a change in pull request #2761:
URL: https://github.com/apache/ozone/pull/2761#discussion_r734331394
##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/OzoneClientProducer.java
##########
@@ -137,6 +137,11 @@ private OzoneClient getClient(OzoneConfiguration config)
LOG.debug("Error during Client Creation: ", ex);
}
throw wrapOS3Exception(ex);
+ } catch(InterruptedException ex){
+ if (LOG.isDebugEnabled()) {
Review comment:
Thanks to @jojochuang for reviewing, I will simplify the logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] siddhantsangwan commented on a change in pull request #2761: HDDS-5888. Handle InterruptedException in OzoneClientProducer and ContainerBalancer
Posted by GitBox <gi...@apache.org>.
siddhantsangwan commented on a change in pull request #2761:
URL: https://github.com/apache/ozone/pull/2761#discussion_r734285314
##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancer.java
##########
@@ -783,6 +784,7 @@ public void stop() {
try {
currentBalancingThread.join();
} catch (InterruptedException ignored) {
Review comment:
Thanks for fixing this @sky76093016 . Small suggestion:
```suggestion
} catch (InterruptedException exception) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang merged pull request #2761: HDDS-5888. Handle InterruptedException in OzoneClientProducer and ContainerBalancer
Posted by GitBox <gi...@apache.org>.
jojochuang merged pull request #2761:
URL: https://github.com/apache/ozone/pull/2761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on pull request #2761: HDDS-5888. Handle InterruptedException in OzoneClientProducer and ContainerBalancer
Posted by GitBox <gi...@apache.org>.
jojochuang commented on pull request #2761:
URL: https://github.com/apache/ozone/pull/2761#issuecomment-949586194
Merged. THanks @sky76093016 @siddhantsangwan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org