[GitHub] [accumulo] ctubbsii commented on pull request #2197: Per table crypto + other crypto improvements

[GitBox <gi...@apache.org>]

ctubbsii commented on PR #2197:
URL: https://github.com/apache/accumulo/pull/2197#issuecomment-1151286437

   > @ctubbsii I re-base'd my per-table crypto changes again with latest for 2.1. Did you want to take another look at this PR before I rewrite the tests?
   
   I do want to take another look, but please don't let me hold you up in making progress.
   
   > There are a lot of changes but I think the design is solid. Here is a summary of the big updates for this feature:
   > 
   > 1. New `CryptoFactoryLoader` class. This class replaces `CryptoServiceFactory`. It can create a new instance of CryptoFactory and has convenience methods to get the CryptoService directly.
   
   My understanding is that this is just an internal utility class to load the configured SPI CryptoFactory instance that is intended to be a singleton for the process. Is that correct?
   
   > 2. New `CryptoFactory` interface. Single method: `  CryptoService getService(CryptoEnvironment environment, Map<String,String> properties)`
   
   I think I prefer the name CryptoServiceFactory, since it builds CryptoService objects and not Crypto objects. Another name could be something like FileCryptoModule to make it more clear that it's a comprehensive "black box" that is responsible for file encryption/decryption and to avoid the "Factory" terminology.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org