You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@geode.apache.org by bs...@apache.org on 2019/04/02 20:29:10 UTC
[geode] branch feature/GEODE-6583 updated: fix for failing unit test
This is an automated email from the ASF dual-hosted git repository.
bschuchardt pushed a commit to branch feature/GEODE-6583
in repository https://gitbox.apache.org/repos/asf/geode.git
The following commit(s) were added to refs/heads/feature/GEODE-6583 by this push:
new 24fc6ce fix for failing unit test
24fc6ce is described below
commit 24fc6ce20cc53487d930eb70bf450caec0b4b58d
Author: Bruce Schuchardt <bs...@pivotal.io>
AuthorDate: Tue Apr 2 13:24:36 2019 -0700
fix for failing unit test
---
.../internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java | 2 +-
.../geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java b/geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java
index 524d785..491f2db 100644
--- a/geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java
+++ b/geode-core/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorJUnitTest.java
@@ -630,7 +630,7 @@ public class GMSHealthMonitorJUnitTest {
boolean available = gmsHealthMonitor.checkIfAvailable(memberToCheck, "Not responding", false);
assertFalse(available);
verify(joinLeave, never()).remove(isA(InternalDistributedMember.class), isA(String.class));
- assertFalse(gmsHealthMonitor.isSuspectMember(memberToCheck));
+ assertTrue(gmsHealthMonitor.isSuspectMember(memberToCheck));
}
diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
index aadae82..9c57afc 100644
--- a/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
+++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
@@ -407,6 +407,7 @@ public class GMSHealthMonitor implements HealthMonitor, MessageHandler {
// it's okay to not synchronize here - if we happen to create another detector
// for this member in another thread it will be pretty equivalent to the one created here
logger.info("Creating new failure detector for {}", member);
+ // TODO consider giving different kinds of members different thresholds
final int threshold = Integer.getInteger("geode.phiAccrualThreshold", 10);
final int sampleSize = Integer.getInteger("geode.phiAccrualSampleSize", 200);
final int minStdDev = Integer.getInteger("geode.phiAccrualMinimumStandardDeviation", 100);