You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/20 05:25:09 UTC
[GitHub] [hudi] xushiyan opened a new pull request, #6722: [HUDI-4326] Fix hive sync serde properties
xushiyan opened a new pull request, #6722:
URL: https://github.com/apache/hudi/pull/6722
### Change Logs
Improve API and refactor code about metasync for serde properties.
### Impact
**Risk level: low**
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xushiyan commented on a diff in pull request #6722: [HUDI-4326] Fix hive sync serde properties
Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #6722:
URL: https://github.com/apache/hudi/pull/6722#discussion_r974919332
##########
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java:
##########
@@ -303,6 +301,7 @@ public void testSyncCOWTableWithProperties(boolean useSchemaFromCommitMetadata,
hiveDriver.run("SHOW CREATE TABLE " + dbTableName);
hiveDriver.getResults(results);
String ddl = String.join("\n", results);
+ assertTrue(ddl.contains(String.format("ROW FORMAT SERDE \n '%s'", ParquetHiveSerDe.class.getName())));
Review Comment:
at least the hive version used for the test is fixed now, so it'll be always formatted like that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6722: [HUDI-4326] Fix hive sync serde properties
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6722:
URL: https://github.com/apache/hudi/pull/6722#issuecomment-1251874266
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e70039066ec51b7328e4f69cb2f266bdd1cc065e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11521",
"triggerID" : "e70039066ec51b7328e4f69cb2f266bdd1cc065e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e70039066ec51b7328e4f69cb2f266bdd1cc065e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11521)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #6722: [HUDI-4326] Fix hive sync serde properties
Posted by GitBox <gi...@apache.org>.
codope merged PR #6722:
URL: https://github.com/apache/hudi/pull/6722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a diff in pull request #6722: [HUDI-4326] Fix hive sync serde properties
Posted by GitBox <gi...@apache.org>.
codope commented on code in PR #6722:
URL: https://github.com/apache/hudi/pull/6722#discussion_r974911483
##########
hudi-sync/hudi-hive-sync/src/test/java/org/apache/hudi/hive/TestHiveSyncTool.java:
##########
@@ -303,6 +301,7 @@ public void testSyncCOWTableWithProperties(boolean useSchemaFromCommitMetadata,
hiveDriver.run("SHOW CREATE TABLE " + dbTableName);
hiveDriver.getResults(results);
String ddl = String.join("\n", results);
+ assertTrue(ddl.contains(String.format("ROW FORMAT SERDE \n '%s'", ParquetHiveSerDe.class.getName())));
Review Comment:
Is `ROW FORMAT SERDE \n '%s'` a fixed format? `getTable` API in hive client was introduced previously just for this testing purpose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6722: [HUDI-4326] Fix hive sync serde properties
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6722:
URL: https://github.com/apache/hudi/pull/6722#issuecomment-1251871135
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e70039066ec51b7328e4f69cb2f266bdd1cc065e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e70039066ec51b7328e4f69cb2f266bdd1cc065e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e70039066ec51b7328e4f69cb2f266bdd1cc065e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org