[GitHub] [ignite-3] rpuch commented on a diff in pull request #1022: IGNITE-17336 Spill-out to disk support for volatile RAFT log storage

[GitBox <gi...@apache.org>]

rpuch commented on code in PR #1022:
URL: https://github.com/apache/ignite-3/pull/1022#discussion_r951130686


##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/storage/impl/Logs.java:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.ignite.raft.jraft.storage.impl;
+
+import java.util.List;
+import org.apache.ignite.raft.jraft.Lifecycle;
+import org.apache.ignite.raft.jraft.entity.LogEntry;
+import org.apache.ignite.raft.jraft.option.LogStorageOptions;
+import org.apache.ignite.raft.jraft.storage.Storage;
+
+/**
+ * Log entry storage (used for internal needs of {@link VolatileLogStorage}).
+ */
+interface Logs extends Lifecycle<LogStorageOptions>, Storage {
+    /**
+     * Get logEntry by index.
+     */
+    LogEntry getEntry(final long index);
+
+    /**
+     * Append entries to log.
+     */
+    void appendEntry(final LogEntry entry);
+
+    /**
+     * Append entries to log, return append success number.
+     */
+    void appendEntries(final List<LogEntry> entries);
+
+    /**
+     * Delete logs from storage's head, [first_log_index, first_index_kept) will be discarded.
+     */
+    void truncatePrefix(final long firstIndexKept);
+
+    /**
+     * Delete uncommitted logs from storage's tail, (last_index_kept, last_log_index] will be discarded.
+     */
+    void truncateSuffix(final long lastIndexKept);
+
+    /**
+     * Drop all the existing logs and reset next log index to |next_log_index|. This function is called after installing

Review Comment:
   Those are internal details of JRaft implementation, not terms from the raft paper



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org