You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/08 16:30:39 UTC
[GitHub] [incubator-nuttx] spiriou opened a new pull request #2247: Adb examples
spiriou opened a new pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247
## Summary
Add defconfig examples to use Android Debug Bridge feature on sim and stm32/photon targets.
## Impact
## Testing
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723649152
@spiriou make distclean is leaving these files around
```
Untracked files:
339 (use "git add <file>..." to include in what will be committed)
340 system/adb/microADB/
341 system/libuv/libuv-1.38.1/
342 system/libuv/v1.38.1.zip
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou commented on a change in pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
spiriou commented on a change in pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#discussion_r519465659
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,113 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
+CONFIG_FSUTILS_PASSWD_READONLY=y
+CONFIG_FS_BINFS=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_ROMFS=y
+CONFIG_FS_TMPFS=y
+CONFIG_IDLETHREAD_STACKSIZE=4096
+CONFIG_LIBC_EXECFUNCS=y
+CONFIG_LIBUV=y
+CONFIG_LIBUV_FS_POLL=y
+CONFIG_LIBUV_NPOLLWAITERS=16
+CONFIG_LIBUV_PIPE=y
+CONFIG_LIBUV_TCP=y
+CONFIG_LIBUV_UNIT_TESTS=y
+CONFIG_LIBUV_WQ_THREADS_COUNT=2
+CONFIG_LIB_ENVPATH=y
+CONFIG_MAX_TASKS=64
+CONFIG_NET=y
+CONFIG_NETINIT_DRIPADDR=0x0a000101
+CONFIG_NETINIT_IPADDR=0x0a000102
+CONFIG_NETUTILS_PING=y
+CONFIG_NETUTILS_WEBSERVER=y
+CONFIG_NET_ICMP=y
+CONFIG_NET_LOOPBACK=y
+CONFIG_NET_LOOPBACK_PKTSIZE=64
+CONFIG_NET_PKT=y
+CONFIG_NET_SOCKOPTS=y
+CONFIG_NET_TCP=y
+CONFIG_NET_TCPBACKLOG=y
+CONFIG_NET_TCP_KEEPALIVE=y
+CONFIG_NET_UDP=y
+CONFIG_NFILE_DESCRIPTORS=32
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_ARCHROMFS=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FATDEVNO=2
+CONFIG_NSH_FILE_APPS=y
+CONFIG_NSH_MOTD=y
+CONFIG_NSH_MOTD_STRING="MOTD: username=admin password=Administrator"
+CONFIG_NSH_READLINE=y
+CONFIG_NSH_ROMFSDEVNO=1
+CONFIG_NSH_ROMFSETC=y
+CONFIG_PATH_INITIAL="/bin"
+CONFIG_PIPES=y
+CONFIG_POSIX_SPAWN_PROXY_STACKSIZE=2048
+CONFIG_RAMLOG=y
+CONFIG_RAMLOG_BUFSIZE=8192
+CONFIG_RAMLOG_SYSLOG=y
+CONFIG_READLINE_TABCOMPLETION=y
+CONFIG_SCHED_HAVE_PARENT=y
+CONFIG_SCHED_ONEXIT=y
+CONFIG_SDCLONE_DISABLE=y
+CONFIG_SIG_DEFAULT=y
+CONFIG_SIM_M32=y
Review comment:
Done. Let's see how it goes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#discussion_r519465091
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,113 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
+CONFIG_FSUTILS_PASSWD_READONLY=y
+CONFIG_FS_BINFS=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_ROMFS=y
+CONFIG_FS_TMPFS=y
+CONFIG_IDLETHREAD_STACKSIZE=4096
+CONFIG_LIBC_EXECFUNCS=y
+CONFIG_LIBUV=y
+CONFIG_LIBUV_FS_POLL=y
+CONFIG_LIBUV_NPOLLWAITERS=16
+CONFIG_LIBUV_PIPE=y
+CONFIG_LIBUV_TCP=y
+CONFIG_LIBUV_UNIT_TESTS=y
+CONFIG_LIBUV_WQ_THREADS_COUNT=2
+CONFIG_LIB_ENVPATH=y
+CONFIG_MAX_TASKS=64
+CONFIG_NET=y
+CONFIG_NETINIT_DRIPADDR=0x0a000101
+CONFIG_NETINIT_IPADDR=0x0a000102
+CONFIG_NETUTILS_PING=y
+CONFIG_NETUTILS_WEBSERVER=y
+CONFIG_NET_ICMP=y
+CONFIG_NET_LOOPBACK=y
+CONFIG_NET_LOOPBACK_PKTSIZE=64
+CONFIG_NET_PKT=y
+CONFIG_NET_SOCKOPTS=y
+CONFIG_NET_TCP=y
+CONFIG_NET_TCPBACKLOG=y
+CONFIG_NET_TCP_KEEPALIVE=y
+CONFIG_NET_UDP=y
+CONFIG_NFILE_DESCRIPTORS=32
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_ARCHROMFS=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FATDEVNO=2
+CONFIG_NSH_FILE_APPS=y
+CONFIG_NSH_MOTD=y
+CONFIG_NSH_MOTD_STRING="MOTD: username=admin password=Administrator"
+CONFIG_NSH_READLINE=y
+CONFIG_NSH_ROMFSDEVNO=1
+CONFIG_NSH_ROMFSETC=y
+CONFIG_PATH_INITIAL="/bin"
+CONFIG_PIPES=y
+CONFIG_POSIX_SPAWN_PROXY_STACKSIZE=2048
+CONFIG_RAMLOG=y
+CONFIG_RAMLOG_BUFSIZE=8192
+CONFIG_RAMLOG_SYSLOG=y
+CONFIG_READLINE_TABCOMPLETION=y
+CONFIG_SCHED_HAVE_PARENT=y
+CONFIG_SCHED_ONEXIT=y
+CONFIG_SDCLONE_DISABLE=y
+CONFIG_SIG_DEFAULT=y
+CONFIG_SIM_M32=y
Review comment:
@spiriou Can you try not setting this? Usually we do not do a 32bit build unless it is required, it also will not build on macOS. I think this might actually resolve the issue since I dont think 32bit libz is installed in the build container.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou commented on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
spiriou commented on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723651121
> @spiriou make distclean is leaving these files around
>
> ```
>
> Untracked files:
>
> 339 (use "git add <file>..." to include in what will be committed)
>
> 340 system/adb/microADB/
>
> 341 system/libuv/libuv-1.38.1/
>
> 342 system/libuv/v1.38.1.zip
> ```
This should not happen has those files are deleted in distclean:
distclean::
$(call DELDIR, $(LIBUV_UNPACKDIR))
$(call DELFILE, $(LIBUV_DIR)/$(CONFIG_LIBUV_TARBALL))
distclean::
$(call DELDIR, $(ADB_UNPACKDIR))
Is there a way to run "Build / Linux (arm-08)" again ?
There is the photon:adb defconfig so it could be interesting to get the build logs too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#discussion_r519683903
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,112 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
+CONFIG_FSUTILS_PASSWD_READONLY=y
+CONFIG_FS_BINFS=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_ROMFS=y
+CONFIG_FS_TMPFS=y
+CONFIG_IDLETHREAD_STACKSIZE=4096
+CONFIG_LIBC_EXECFUNCS=y
+CONFIG_LIBUV=y
+CONFIG_LIBUV_FS_POLL=y
+CONFIG_LIBUV_NPOLLWAITERS=16
+CONFIG_LIBUV_PIPE=y
+CONFIG_LIBUV_TCP=y
+CONFIG_LIBUV_UNIT_TESTS=y
Review comment:
how about we add new project for uv
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#discussion_r519467270
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,113 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
+CONFIG_FSUTILS_PASSWD_READONLY=y
+CONFIG_FS_BINFS=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_ROMFS=y
+CONFIG_FS_TMPFS=y
+CONFIG_IDLETHREAD_STACKSIZE=4096
+CONFIG_LIBC_EXECFUNCS=y
+CONFIG_LIBUV=y
+CONFIG_LIBUV_FS_POLL=y
+CONFIG_LIBUV_NPOLLWAITERS=16
+CONFIG_LIBUV_PIPE=y
+CONFIG_LIBUV_TCP=y
+CONFIG_LIBUV_UNIT_TESTS=y
+CONFIG_LIBUV_WQ_THREADS_COUNT=2
+CONFIG_LIB_ENVPATH=y
+CONFIG_MAX_TASKS=64
+CONFIG_NET=y
+CONFIG_NETINIT_DRIPADDR=0x0a000101
+CONFIG_NETINIT_IPADDR=0x0a000102
+CONFIG_NETUTILS_PING=y
+CONFIG_NETUTILS_WEBSERVER=y
+CONFIG_NET_ICMP=y
+CONFIG_NET_LOOPBACK=y
+CONFIG_NET_LOOPBACK_PKTSIZE=64
+CONFIG_NET_PKT=y
+CONFIG_NET_SOCKOPTS=y
+CONFIG_NET_TCP=y
+CONFIG_NET_TCPBACKLOG=y
+CONFIG_NET_TCP_KEEPALIVE=y
+CONFIG_NET_UDP=y
+CONFIG_NFILE_DESCRIPTORS=32
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_ARCHROMFS=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FATDEVNO=2
+CONFIG_NSH_FILE_APPS=y
+CONFIG_NSH_MOTD=y
+CONFIG_NSH_MOTD_STRING="MOTD: username=admin password=Administrator"
+CONFIG_NSH_READLINE=y
+CONFIG_NSH_ROMFSDEVNO=1
+CONFIG_NSH_ROMFSETC=y
+CONFIG_PATH_INITIAL="/bin"
+CONFIG_PIPES=y
+CONFIG_POSIX_SPAWN_PROXY_STACKSIZE=2048
+CONFIG_RAMLOG=y
+CONFIG_RAMLOG_BUFSIZE=8192
+CONFIG_RAMLOG_SYSLOG=y
+CONFIG_READLINE_TABCOMPLETION=y
+CONFIG_SCHED_HAVE_PARENT=y
+CONFIG_SCHED_ONEXIT=y
+CONFIG_SDCLONE_DISABLE=y
+CONFIG_SIG_DEFAULT=y
+CONFIG_SIM_M32=y
Review comment:
@spiriou If you do want to trigger a build that will not fail fast you can disable it in your PR, we just need to make sure that does not get merged.
https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-syntax-for-github-actions#jobsjob_idstrategyfail-fast
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou commented on a change in pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
spiriou commented on a change in pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#discussion_r519466881
##########
File path: boards/arm/stm32/photon/src/stm32_composite.c
##########
@@ -0,0 +1,162 @@
+/****************************************************************************
+ * boards/arm/stm32/photon/src/stm32_composite.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdio.h>
+#include <debug.h>
+#include <errno.h>
+
+#include <nuttx/board.h>
+#include <nuttx/usb/usbdev.h>
+#include <nuttx/usb/adb.h>
+#include <nuttx/usb/composite.h>
+
+#include "stm32.h"
+
+#if defined(CONFIG_BOARDCTL_USBDEVCTRL) && defined(CONFIG_USBDEV_COMPOSITE)
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: board_composite0_connect
+ *
+ * Description:
+ * Connect the USB composite device on the specified USB device port for
+ * configuration 0.
+ *
+ * Input Parameters:
+ * port - The USB device port.
+ *
+ * Returned Value:
+ * A non-NULL handle value is returned on success. NULL is returned on
+ * any failure.
+ *
+ ****************************************************************************/
+
+static FAR void *board_composite0_connect(int port)
+{
+ /* Here we are composing the configuration of the usb composite device.
+ *
+ * The standard is to use one CDC/ACM and one USB mass storage device.
+ */
+
+ /* Change "dev" array size to add more composite devs */
+
+ struct composite_devdesc_s dev[1];
+ int ifnobase = 0;
+ int strbase = (COMPOSITE_NSTRIDS) - 1;
+
+ int dev_idx = 0;
+
+ /* Configure the ADB USB device */
+
+ /* Ask the adb driver to fill in the constants we didn't
+ * know here.
+ */
+
+ usbdev_adb_get_composite_devdesc(&dev[dev_idx]);
Review comment:
Check CONFIG_ADBUSB here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou edited a comment on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
spiriou edited a comment on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723648134
@acassis indeed. I added sim:adb config and it fails, but I have no idea why yet ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2247: add defconfig example for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-726531930
@spiriou I'll merge this as it is, we can refine a sim configuration later. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723657228
Ok here is the issue. While you are correct that the `make distclean` does clean these files up, they are not in the gitignore which is required. You can see the build check here that is run in `cibuild.sh`. So after you run a build, run `git status` in both the os and app directory and make sure it comes out clean.
```
function build {
echo " Building NuttX..."
makefunc
if [ ${SAVEARTIFACTS} -eq 1 ]; then
artifactconfigdir=$ARTIFACTDIR/$(echo $config | sed "s/:/\//")/
mkdir -p $artifactconfigdir
xargs -I "{}" cp "{}" $artifactconfigdir < $nuttx/nuttx.manifest
fi
# Ensure defconfig in the canonical form
if ! ./tools/refresh.sh --silent $config; then
fail=1
fi
# Ensure nuttx and apps directory in clean state
if [ -d $nuttx/.git ] || [ -d $APPSDIR/.git ]; then
if [[ -n $(git -C $nuttx status -s) ]]; then
git -C $nuttx status
fail=1
fi
if [[ -n $(git -C $APPSDIR status -s) ]]; then
git -C $APPSDIR status
fail=1
fi
fi
return $fail
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton merged pull request #2247: add defconfig example for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
btashton merged pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#discussion_r519683903
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,112 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
+CONFIG_FSUTILS_PASSWD_READONLY=y
+CONFIG_FS_BINFS=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_ROMFS=y
+CONFIG_FS_TMPFS=y
+CONFIG_IDLETHREAD_STACKSIZE=4096
+CONFIG_LIBC_EXECFUNCS=y
+CONFIG_LIBUV=y
+CONFIG_LIBUV_FS_POLL=y
+CONFIG_LIBUV_NPOLLWAITERS=16
+CONFIG_LIBUV_PIPE=y
+CONFIG_LIBUV_TCP=y
+CONFIG_LIBUV_UNIT_TESTS=y
Review comment:
how about we add new project for uv?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#discussion_r519466730
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,113 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
+CONFIG_FSUTILS_PASSWD_READONLY=y
+CONFIG_FS_BINFS=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_ROMFS=y
+CONFIG_FS_TMPFS=y
+CONFIG_IDLETHREAD_STACKSIZE=4096
+CONFIG_LIBC_EXECFUNCS=y
+CONFIG_LIBUV=y
+CONFIG_LIBUV_FS_POLL=y
+CONFIG_LIBUV_NPOLLWAITERS=16
+CONFIG_LIBUV_PIPE=y
+CONFIG_LIBUV_TCP=y
+CONFIG_LIBUV_UNIT_TESTS=y
+CONFIG_LIBUV_WQ_THREADS_COUNT=2
+CONFIG_LIB_ENVPATH=y
+CONFIG_MAX_TASKS=64
+CONFIG_NET=y
+CONFIG_NETINIT_DRIPADDR=0x0a000101
+CONFIG_NETINIT_IPADDR=0x0a000102
+CONFIG_NETUTILS_PING=y
+CONFIG_NETUTILS_WEBSERVER=y
+CONFIG_NET_ICMP=y
+CONFIG_NET_LOOPBACK=y
+CONFIG_NET_LOOPBACK_PKTSIZE=64
+CONFIG_NET_PKT=y
+CONFIG_NET_SOCKOPTS=y
+CONFIG_NET_TCP=y
+CONFIG_NET_TCPBACKLOG=y
+CONFIG_NET_TCP_KEEPALIVE=y
+CONFIG_NET_UDP=y
+CONFIG_NFILE_DESCRIPTORS=32
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_ARCHROMFS=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FATDEVNO=2
+CONFIG_NSH_FILE_APPS=y
+CONFIG_NSH_MOTD=y
+CONFIG_NSH_MOTD_STRING="MOTD: username=admin password=Administrator"
+CONFIG_NSH_READLINE=y
+CONFIG_NSH_ROMFSDEVNO=1
+CONFIG_NSH_ROMFSETC=y
+CONFIG_PATH_INITIAL="/bin"
+CONFIG_PIPES=y
+CONFIG_POSIX_SPAWN_PROXY_STACKSIZE=2048
+CONFIG_RAMLOG=y
+CONFIG_RAMLOG_BUFSIZE=8192
+CONFIG_RAMLOG_SYSLOG=y
+CONFIG_READLINE_TABCOMPLETION=y
+CONFIG_SCHED_HAVE_PARENT=y
+CONFIG_SCHED_ONEXIT=y
+CONFIG_SDCLONE_DISABLE=y
+CONFIG_SIG_DEFAULT=y
+CONFIG_SIM_M32=y
Review comment:
Yeah I'll keep an eye on it. Unfortunately it is hard to do one-off testing in the CI we have it set to fail fast because otherwise we clog up the works, but that is less desirable. GitHub supports a feature now where we can trigger a build with parameters, which might be useful to do thigs like running in verbose mode / not failing fast / selecting a single configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
btashton commented on a change in pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#discussion_r519488230
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,112 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
Review comment:
No need for password file support
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,112 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
+CONFIG_FSUTILS_PASSWD_READONLY=y
+CONFIG_FS_BINFS=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_ROMFS=y
+CONFIG_FS_TMPFS=y
+CONFIG_IDLETHREAD_STACKSIZE=4096
+CONFIG_LIBC_EXECFUNCS=y
+CONFIG_LIBUV=y
+CONFIG_LIBUV_FS_POLL=y
+CONFIG_LIBUV_NPOLLWAITERS=16
+CONFIG_LIBUV_PIPE=y
+CONFIG_LIBUV_TCP=y
+CONFIG_LIBUV_UNIT_TESTS=y
Review comment:
remove the unit tests?
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,112 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
+CONFIG_FSUTILS_PASSWD_READONLY=y
+CONFIG_FS_BINFS=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_ROMFS=y
+CONFIG_FS_TMPFS=y
+CONFIG_IDLETHREAD_STACKSIZE=4096
+CONFIG_LIBC_EXECFUNCS=y
+CONFIG_LIBUV=y
+CONFIG_LIBUV_FS_POLL=y
+CONFIG_LIBUV_NPOLLWAITERS=16
+CONFIG_LIBUV_PIPE=y
+CONFIG_LIBUV_TCP=y
+CONFIG_LIBUV_UNIT_TESTS=y
+CONFIG_LIBUV_WQ_THREADS_COUNT=2
+CONFIG_LIB_ENVPATH=y
+CONFIG_MAX_TASKS=64
+CONFIG_NET=y
+CONFIG_NETINIT_DRIPADDR=0x0a000101
+CONFIG_NETINIT_IPADDR=0x0a000102
+CONFIG_NETUTILS_PING=y
+CONFIG_NETUTILS_WEBSERVER=y
Review comment:
@spiriou the webserver is enabled here.
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,112 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
+CONFIG_FSUTILS_PASSWD_READONLY=y
+CONFIG_FS_BINFS=y
+CONFIG_FS_FAT=y
Review comment:
We probably do not need binfs, romfs, or fat. procfs is useful.
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,112 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
Review comment:
Sounds like we also dont need this to be enabled.
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,112 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
+CONFIG_FSUTILS_PASSWD_READONLY=y
+CONFIG_FS_BINFS=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_ROMFS=y
+CONFIG_FS_TMPFS=y
+CONFIG_IDLETHREAD_STACKSIZE=4096
+CONFIG_LIBC_EXECFUNCS=y
+CONFIG_LIBUV=y
+CONFIG_LIBUV_FS_POLL=y
+CONFIG_LIBUV_NPOLLWAITERS=16
+CONFIG_LIBUV_PIPE=y
+CONFIG_LIBUV_TCP=y
+CONFIG_LIBUV_UNIT_TESTS=y
+CONFIG_LIBUV_WQ_THREADS_COUNT=2
+CONFIG_LIB_ENVPATH=y
+CONFIG_MAX_TASKS=64
+CONFIG_NET=y
+CONFIG_NETINIT_DRIPADDR=0x0a000101
+CONFIG_NETINIT_IPADDR=0x0a000102
+CONFIG_NETUTILS_PING=y
+CONFIG_NETUTILS_WEBSERVER=y
+CONFIG_NET_ICMP=y
+CONFIG_NET_LOOPBACK=y
+CONFIG_NET_LOOPBACK_PKTSIZE=64
+CONFIG_NET_PKT=y
+CONFIG_NET_SOCKOPTS=y
+CONFIG_NET_TCP=y
+CONFIG_NET_TCPBACKLOG=y
+CONFIG_NET_TCP_KEEPALIVE=y
+CONFIG_NET_UDP=y
+CONFIG_NFILE_DESCRIPTORS=32
+CONFIG_NSH_ARCHINIT=y
+CONFIG_NSH_ARCHROMFS=y
+CONFIG_NSH_BUILTIN_APPS=y
+CONFIG_NSH_FATDEVNO=2
+CONFIG_NSH_FILE_APPS=y
+CONFIG_NSH_MOTD=y
Review comment:
MOTD support can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou edited a comment on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
spiriou edited a comment on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723651121
> @spiriou make distclean is leaving these files around
>
> ```
>
> Untracked files:
>
> 339 (use "git add <file>..." to include in what will be committed)
>
> 340 system/adb/microADB/
>
> 341 system/libuv/libuv-1.38.1/
>
> 342 system/libuv/v1.38.1.zip
> ```
This should not happen as those files are deleted in distclean:
distclean::
$(call DELDIR, $(LIBUV_UNPACKDIR))
$(call DELFILE, $(LIBUV_DIR)/$(CONFIG_LIBUV_TARBALL))
distclean::
$(call DELDIR, $(ADB_UNPACKDIR))
Is there a way to run "Build / Linux (arm-08)" again ?
There is the photon:adb defconfig so it could be interesting to get the build logs too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723669618
Ok looks like it's actual build issues now (cast warning)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton edited a comment on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
btashton edited a comment on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723657228
Ok here is the issue. While you are correct that the `make distclean` does clean these files up, they are not in the gitignore which is required. You can see the build check here that is run in `cibuild.sh`. So after you run a build, run `git status` in both the os and app directory and make sure it comes out clean.
```
function build {
echo " Building NuttX..."
makefunc
if [ ${SAVEARTIFACTS} -eq 1 ]; then
artifactconfigdir=$ARTIFACTDIR/$(echo $config | sed "s/:/\//")/
mkdir -p $artifactconfigdir
xargs -I "{}" cp "{}" $artifactconfigdir < $nuttx/nuttx.manifest
fi
# Ensure defconfig in the canonical form
if ! ./tools/refresh.sh --silent $config; then
fail=1
fi
# Ensure nuttx and apps directory in clean state
if [ -d $nuttx/.git ] || [ -d $APPSDIR/.git ]; then
if [[ -n $(git -C $nuttx status -s) ]]; then
git -C $nuttx status
fail=1
fi
if [[ -n $(git -C $APPSDIR status -s) ]]; then
git -C $APPSDIR status
fail=1
fi
fi
return $fail
}
```
This fix will be in the apps repo, so we will need to make that change there and merge it then we can rebase and kick this build again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou commented on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
spiriou commented on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723670228
@btashton yes and I don't know why the webserver is being built as it is disabled in the .config file.
I'll submit a patch to fix the cast warning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou commented on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
spiriou commented on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723658393
Thanks @btashton I'm submitting a PR in apps repo now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723659487
Thanks I just merged it. You might need to rebase/amend your last commit to trigger the change in the PR build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou commented on a change in pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
spiriou commented on a change in pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#discussion_r519672103
##########
File path: boards/sim/sim/sim/configs/adb/defconfig
##########
@@ -0,0 +1,112 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed .config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that includes your
+# modifications.
+#
+# CONFIG_NSH_CMDOPT_HEXDUMP is not set
+# CONFIG_SIG_SIGPIPE_ACTION is not set
+# CONFIG_SIG_SIGSTOP_ACTION is not set
+CONFIG_ADBD_AUTHENTICATION=y
+CONFIG_ADBD_AUTH_PUBKEY=y
+CONFIG_ADBD_BOARD_INIT=y
+CONFIG_ADBD_DEVICE_ID="serialno"
+CONFIG_ADBD_FILE_SERVICE=y
+CONFIG_ADBD_LOGCAT_SERVICE=y
+CONFIG_ADBD_NET_INIT=y
+CONFIG_ADBD_SHELL_SERVICE=y
+CONFIG_ADBD_TCP_SERVER=y
+CONFIG_ARCH="sim"
+CONFIG_ARCH_BOARD="sim"
+CONFIG_ARCH_BOARD_SIM=y
+CONFIG_ARCH_CHIP="sim"
+CONFIG_ARCH_SIM=y
+CONFIG_BOARDCTL_APP_SYMTAB=y
+CONFIG_BOARDCTL_POWEROFF=y
+CONFIG_BOARD_LOOPSPERMSEC=0
+CONFIG_BOOT_RUNFROMEXTSRAM=y
+CONFIG_BUILTIN=y
+CONFIG_DEBUG_ERROR=y
+CONFIG_DEBUG_FEATURES=y
+CONFIG_DEBUG_INFO=y
+CONFIG_DEBUG_NET=y
+CONFIG_DEBUG_NET_ERROR=y
+CONFIG_DEBUG_NET_WARN=y
+CONFIG_DEBUG_SYMBOLS=y
+CONFIG_DEBUG_WARN=y
+CONFIG_DEV_FIFO_SIZE=64
+CONFIG_DEV_LOOP=y
+CONFIG_DEV_PIPE_MAXSIZE=64
+CONFIG_DEV_PIPE_SIZE=64
+CONFIG_DEV_URANDOM=y
+CONFIG_DEV_ZERO=y
+CONFIG_EVENT_FD_NPOLLWAITERS=4
+CONFIG_EXAMPLES_HELLO=y
+CONFIG_EXAMPLES_HELLO_STACKSIZE=7168
+CONFIG_EXAMPLES_WEBSERVER=y
+CONFIG_EXAMPLES_WEBSERVER_DRIPADDR=0x0a000101
+CONFIG_EXAMPLES_WEBSERVER_IPADDR=0x0a000102
+CONFIG_FAT_LCNAMES=y
+CONFIG_FAT_LFN=y
+CONFIG_FSUTILS_PASSWD=y
+CONFIG_FSUTILS_PASSWD_READONLY=y
+CONFIG_FS_BINFS=y
+CONFIG_FS_FAT=y
+CONFIG_FS_PROCFS=y
+CONFIG_FS_ROMFS=y
+CONFIG_FS_TMPFS=y
+CONFIG_IDLETHREAD_STACKSIZE=4096
+CONFIG_LIBC_EXECFUNCS=y
+CONFIG_LIBUV=y
+CONFIG_LIBUV_FS_POLL=y
+CONFIG_LIBUV_NPOLLWAITERS=16
+CONFIG_LIBUV_PIPE=y
+CONFIG_LIBUV_TCP=y
+CONFIG_LIBUV_UNIT_TESTS=y
Review comment:
I would prefer to keep it in order to build this at least in one target so I know when libuv breaks again at compile time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] spiriou commented on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
spiriou commented on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723648134
@acassis indeed, but I have no idea why yet ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #2247: add defconfig examples for ADB (Android Debug Bridge)
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #2247:
URL: https://github.com/apache/incubator-nuttx/pull/2247#issuecomment-723647373
Is it failing in the "sim" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org