Re: svn commit: r1882518 - /subversion/branches/javahl-1.14-fixes/subversion/bindings/javahl/tests/org/apache/subversion/javahl/BasicTests.java

[Daniel Shahaf <d....@daniel.shahaf.name>]

Alexandr Miloslavskiy wrote on Fri, Jan 29, 2021 at 21:52:44 +0100:
> On 29.01.2021 21:47, Johan Corveleyn wrote:
> > Looks good! Looks like everything is good to go now for your javahl
> > fixes in 1.14.1 :-).
> > 
> > Just to clarify: backports to bindings require only 2 votes (in fact
> > even only one +1, and one +0 or "concept +1"). Backports to core code
> > require 3 votes (or for non-LTS releases also just 2 votes). See [1]
> > for the official explanation.
> > 
> > And, as you did correctly, usually the one who adds the last needed
> > vote moves the section below the "Approved changes" line (provided
> > there are no vetoes). This helps for our nightly backport bot which
> > automatically processes the STATUS file, and merges everything below
> > the Approved line (with the svn-role account).
> > 
> > [1] http://subversion.apache.org/docs/community-guide/releasing.html#release-stabilization-how-many-votes
> 
> Perfect, thanks for taking so much time to explain everything to me!

For future reference, automation is available for casting votes on
existing nominations and for entering new nominations; see
«tools/dist/backport.pl --help» and «tools/dist/nominate.pl --help»
(the latter is a symlink to the former).  Example run:

{{{
% svn info --show-item=url
https://svn.apache.org/repos/asf/subversion/branches/1.14.x
% svn up -q -r 1886034 
% svn st -q
% readlink b
../trunk/tools/dist/backport.pl
% ./b javahl 


=== Candidate changes:


Skipping r1877310 (doesn't match pattern):
Add a test for issue #4711 "invalid xml file produced by svn log --xml[...]


Skipping r1883355 (doesn't match pattern):
Use the APR-1.4+ API for flushing file contents to disk.


Skipping the r1878379 group (doesn't match pattern):
Distinguish configure scripts on release mode and non release mode.


Skipping the 1.14.x-r1881534-no-crlf branch (doesn't match pattern):
r1881534 (without CRLF problem)[...]


>>> r1886029:
r1886029

Fix several crashes and JNI warnings in javahl TunnelAgent.

  +1: jcorvel

Run a merge? [y,l,v,±1,±0,q,e,a, ,N,?] v

 * r1886029
   Fix several crashes and JNI warnings in javahl TunnelAgent.
   Justification:
     JavaHL shouldn't crash.
   Votes:
     +1: jcorvel

Run a merge? [y,l,v,±1,±0,q,e,a, ,N,?] a  # In actual use you'd choose 'y' here to review/test the change, before voting on it


>>> r1886029:
r1886029

Fix several crashes and JNI warnings in javahl TunnelAgent.

  +1: jcorvel

Run a merge? [y,l,v,±1,±0,q,e,a, ,N,?] +1


=== Veto-blocked changes:


Skipping the r1881534 group (doesn't match pattern):
Fix issue #4864 "build/ac-macros/macosx.m4: workaround AC_RUN_IFELSE"


=== Approved changes:


Skipping r1882234 (doesn't match pattern):
Fix file name to edit from utf8 to local style.


Skipping r1885953 (doesn't match pattern):
Fix file name encoding and quoting when invoking editor on Windows.


Skipping r1886019 (doesn't match pattern):
Fix a potential NULL dereference in the config file parser.


Skipping r1885983 (doesn't match pattern):
Fix issue #4869: 'svn info --xml' gives wrong 'source-right' of conflict
Index: STATUS
===================================================================
--- STATUS      (revision 1886034)
+++ STATUS      (working copy)
@@ -50,13 +50,6 @@
    Votes:
      +1: hartmannathan, stsp
 
- * r1886029
-   Fix several crashes and JNI warnings in javahl TunnelAgent.
-   Justification:
-     JavaHL shouldn't crash.
-   Votes:
-     +1: jcorvel
-
 Veto-blocked changes:
 =====================
 
@@ -104,3 +97,11 @@
      Bugfix; 'svn info --xml' should give correct results; user complained.
    Votes:
      +1: hartmannathan, stsp, jcorvel
+
+ * r1886029
+   Fix several crashes and JNI warnings in javahl TunnelAgent.
+   Justification:
+     JavaHL shouldn't crash.
+   Votes:
+     +1: jcorvel, danielsh
+
[[[
* STATUS: Vote +1 on r1886029, approving.
]]]
Commit these votes? q

}}}

I think most people just edit STATUS manually, though.

Cheers,

Daniel