[GitHub] [kafka] cmccabe commented on a diff in pull request #13947: KAFKA-15130: Delete remote segments when delete a topic

["cmccabe (via GitHub)" <gi...@apache.org>]

cmccabe commented on code in PR #13947:
URL: https://github.com/apache/kafka/pull/13947#discussion_r1272579577


##########
core/src/main/scala/kafka/server/ReplicaManager.scala:
##########
@@ -526,14 +532,17 @@ class ReplicaManager(val config: KafkaConfig,
   /**
    * Stop the given partitions.
    *
-   * @param partitionsToStop    A map from a topic partition to a boolean indicating
-   *                            whether the partition should be deleted.
+   * @param partitionsToStop                A map from a topic partition to a boolean indicating
+   *                                        whether the partition should be deleted.
+   * @param partitionsMaybeToDeleteRemote   A set of topic partitions that may need to delete
+   *                                        remote segments.
    *
-   * @return                    A map from partitions to exceptions which occurred.
-   *                            If no errors occurred, the map will be empty.
+   * @return                                A map from partitions to exceptions which occurred.
+   *                                        If no errors occurred, the map will be empty.
    */
   protected def stopPartitions(
-    partitionsToStop: Map[TopicPartition, Boolean]
+    partitionsToStop: Map[TopicPartition, Boolean],

Review Comment:
   We can't commit this without KRaft support. ZK mode is deprecated and we cannot add new features there that don't exist in KRaft.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org