You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/23 10:04:51 UTC
[GitHub] [apisix] membphis opened a new pull request #2286: feat(http-logger): support to concat multiple log with separator.
membphis opened a new pull request #2286:
URL: https://github.com/apache/apisix/pull/2286
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #2286: feat(http-logger): support to concat multiple log with separator.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2286:
URL: https://github.com/apache/apisix/pull/2286#issuecomment-698056169
> I have a doubt, why not use a array json, but concat by '\n' ?
ignore that, I see it supports two ways..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #2286: feat(http-logger): support to concat multiple log with separator.
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2286:
URL: https://github.com/apache/apisix/pull/2286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2286: feat(http-logger): support to concat multiple log with separator.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2286:
URL: https://github.com/apache/apisix/pull/2286#discussion_r493989414
##########
File path: apisix/plugins/http-logger.lua
##########
@@ -110,13 +113,6 @@ local function send_http_data(conf, log_message)
.. "body[" .. httpc_res:read_body() .. "]"
end
- -- keep the connection alive
- ok, err = httpc:set_keepalive(conf.keepalive)
Review comment:
if we want to call `set_keepalive`, need to define them first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on a change in pull request #2286: feat(http-logger): support to concat multiple log with separator.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #2286:
URL: https://github.com/apache/apisix/pull/2286#discussion_r493987640
##########
File path: apisix/plugins/http-logger.lua
##########
@@ -110,13 +113,6 @@ local function send_http_data(conf, log_message)
.. "body[" .. httpc_res:read_body() .. "]"
end
- -- keep the connection alive
- ok, err = httpc:set_keepalive(conf.keepalive)
Review comment:
is it a default action ? although `keepalive` is not in the plugin's schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #2286: feat(http-logger): support to concat multiple log with separator.
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2286:
URL: https://github.com/apache/apisix/pull/2286#issuecomment-698055562
I have a doubt, why not use a array json, but concat by '\n' ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2286: feat(http-logger): support to concat multiple log with separator.
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2286:
URL: https://github.com/apache/apisix/pull/2286#issuecomment-697501950
@gxthrj please take a look at this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2286: feat(http-logger): support to concat multiple log with separator.
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2286:
URL: https://github.com/apache/apisix/pull/2286#discussion_r493989299
##########
File path: apisix/plugins/http-logger.lua
##########
@@ -110,13 +113,6 @@ local function send_http_data(conf, log_message)
.. "body[" .. httpc_res:read_body() .. "]"
end
- -- keep the connection alive
- ok, err = httpc:set_keepalive(conf.keepalive)
Review comment:
the old code is wrong. that is why I delete them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis merged pull request #2286: feat(http-logger): support to concat multiple log with separator.
Posted by GitBox <gi...@apache.org>.
membphis merged pull request #2286:
URL: https://github.com/apache/apisix/pull/2286
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org