You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Jonathan Anstey (JIRA)" <ji...@apache.org> on 2008/10/07 19:25:55 UTC

[jira] Created: (CAMEL-966) Get rid of sleeps in tests

Get rid of sleeps in tests
--------------------------

                 Key: CAMEL-966
                 URL: https://issues.apache.org/activemq/browse/CAMEL-966
             Project: Apache Camel
          Issue Type: Task
    Affects Versions: 1.4.0, 1.5.0
            Reporter: Jonathan Anstey
            Assignee: Jonathan Anstey
            Priority: Trivial


There are a ton of Thread.sleeps used in tests. This makes them prone to failure on slower machines and makes the build take longer. This should be fixed at some point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-966) Get rid of sleeps in tests

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=49205#action_49205 ] 

Claus Ibsen commented on CAMEL-966:
-----------------------------------

Got rid of many sleeps in the ftp component cutting down approx 45 secs.

> Get rid of sleeps in tests
> --------------------------
>
>                 Key: CAMEL-966
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-966
>             Project: Apache Camel
>          Issue Type: Task
>          Components: camel-core, camel-jms, camel-spring
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Jonathan Anstey
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> There are a ton of Thread.sleeps used in tests. This makes them prone to failure on slower machines and makes the build take longer. This should be fixed at some point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-966) Get rid of sleeps in tests

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=49180#action_49180 ] 

Claus Ibsen commented on CAMEL-966:
-----------------------------------

I added two methods on MockEndpoint to set expections for existence of a file

    public void expectedFileExists(final String name) {
    public void expectedFileExists(final String name, final String content) {



> Get rid of sleeps in tests
> --------------------------
>
>                 Key: CAMEL-966
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-966
>             Project: Apache Camel
>          Issue Type: Task
>          Components: camel-core, camel-jms, camel-spring
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Jonathan Anstey
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> There are a ton of Thread.sleeps used in tests. This makes them prone to failure on slower machines and makes the build take longer. This should be fixed at some point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-966) Get rid of sleeps in tests

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-966.
-------------------------------

    Resolution: Fixed

Much better now with FTP and File testing. Dont think we can get it much faster now.

> Get rid of sleeps in tests
> --------------------------
>
>                 Key: CAMEL-966
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-966
>             Project: Apache Camel
>          Issue Type: Task
>          Components: camel-core, camel-jms, camel-spring
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Jonathan Anstey
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> There are a ton of Thread.sleeps used in tests. This makes them prone to failure on slower machines and makes the build take longer. This should be fixed at some point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-966) Get rid of sleeps in tests

Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47563#action_47563 ] 

Jonathan Anstey commented on CAMEL-966:
---------------------------------------

For anyone out there wishing to take a look at this one... a simple way to do this for some tests is to use a mock endpoint at the end of a route that expects a message.

See the following commit for an example:
http://svn.apache.org/viewvc/activemq/camel/trunk/components/camel-jms/src/test/java/org/apache/camel/component/jms/JmsRouteToFileTest.java?r1=702548&r2=702547&pathrev=702548

Of course, we wouldn't want this kinda thing showing up in wiki snippets so use with caution. Its really just an example of what it means to remove the sleeps in tests, in case my description was not clear :)

> Get rid of sleeps in tests
> --------------------------
>
>                 Key: CAMEL-966
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-966
>             Project: Apache Camel
>          Issue Type: Task
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Jonathan Anstey
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> There are a ton of Thread.sleeps used in tests. This makes them prone to failure on slower machines and makes the build take longer. This should be fixed at some point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CAMEL-966) Get rid of sleeps in tests

Posted by "Jonathan Anstey (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Anstey reassigned CAMEL-966:
-------------------------------------

    Assignee:     (was: Jonathan Anstey)

> Get rid of sleeps in tests
> --------------------------
>
>                 Key: CAMEL-966
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-966
>             Project: Apache Camel
>          Issue Type: Task
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Jonathan Anstey
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> There are a ton of Thread.sleeps used in tests. This makes them prone to failure on slower machines and makes the build take longer. This should be fixed at some point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-966) Get rid of sleeps in tests

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-966:
------------------------------

    Fix Version/s: 2.0.0

> Get rid of sleeps in tests
> --------------------------
>
>                 Key: CAMEL-966
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-966
>             Project: Apache Camel
>          Issue Type: Task
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Jonathan Anstey
>            Assignee: Jonathan Anstey
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> There are a ton of Thread.sleeps used in tests. This makes them prone to failure on slower machines and makes the build take longer. This should be fixed at some point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-966) Get rid of sleeps in tests

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47815#action_47815 ] 

Claus Ibsen commented on CAMEL-966:
-----------------------------------

camel-core - the file component unit testing has been improved now.
Committed revision 722828.

> Get rid of sleeps in tests
> --------------------------
>
>                 Key: CAMEL-966
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-966
>             Project: Apache Camel
>          Issue Type: Task
>          Components: camel-core, camel-jms, camel-spring
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Jonathan Anstey
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> There are a ton of Thread.sleeps used in tests. This makes them prone to failure on slower machines and makes the build take longer. This should be fixed at some point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-966) Get rid of sleeps in tests

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen updated CAMEL-966:
------------------------------

    Component/s: camel-spring
                 camel-jms
                 camel-core

> Get rid of sleeps in tests
> --------------------------
>
>                 Key: CAMEL-966
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-966
>             Project: Apache Camel
>          Issue Type: Task
>          Components: camel-core, camel-jms, camel-spring
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Jonathan Anstey
>            Priority: Trivial
>             Fix For: 2.0.0
>
>
> There are a ton of Thread.sleeps used in tests. This makes them prone to failure on slower machines and makes the build take longer. This should be fixed at some point. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.